Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_euclidean_cluster)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_euclidean_cluster #9873

Conversation

vish0012
Copy link
Contributor

@vish0012 vish0012 commented Jan 9, 2025

Description

The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.

Related links

Parent Issue:

How was this PR tested?

Test are done in the following TIER IV internal evaluator:

https://evaluation.ci.tier4.jp/evaluation/reports/bfc0e074-207b-5ece-83e5-fb769f6f7272?project_id=prd_jt
https://evaluation.ci.tier4.jp/evaluation/reports/4df9332b-024e-5907-ada9-fbbcb8c20b3d?project_id=prd_jt
https://evaluation.ci.tier4.jp/evaluation/reports/ce1a0892-d8aa-5729-b25d-6d2d57bea034?project_id=prd_jt

Notes for reviewers

None.

Interface changes

Modifications

Same modification made to both euclidean cluster and voxel grid based euclidean cluster nodes.

Topic Type Topic Name Old Message Type New Message Type
Pub debug/cyclic_time_ms tier4_debug_msgs/Float64Stamped autoware_internal_debug_msgs/Float64Stamped
Pub debug/processing_time_ms tier4_debug_msgs/Float64Stamped autoware_internal_debug_msgs/Float64Stamped
Pub debug/pipeline_latency_ms tier4_debug_msgs/Float64Stamped autoware_internal_debug_msgs/Float64Stamped

Effects on system behavior

None.

…es perception/autoware_euclidean_cluster

Signed-off-by: vish0012 <[email protected]>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r changed the title feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in fil… feat(autoware_euclidean_cluster): tier4_debug_msgs changed to autoware_internal_debug_msgs in fil… Jan 14, 2025
@mitsudome-r mitsudome-r changed the title feat(autoware_euclidean_cluster): tier4_debug_msgs changed to autoware_internal_debug_msgs in fil… feat(autoware_euclidean_cluster)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_euclidean_cluster Jan 17, 2025
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 29.12%. Comparing base (f9c0aa6) to head (a4ba596).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...e_euclidean_cluster/src/euclidean_cluster_node.cpp 0.00% 3 Missing ⚠️
...er/src/voxel_grid_based_euclidean_cluster_node.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9873      +/-   ##
==========================================
- Coverage   29.14%   29.12%   -0.02%     
==========================================
  Files        1423     1426       +3     
  Lines      107820   107828       +8     
  Branches    42236    42246      +10     
==========================================
- Hits        31420    31406      -14     
- Misses      73358    73379      +21     
- Partials     3042     3043       +1     
Flag Coverage Δ *Carryforward flag
differential 4.08% <0.00%> (?)
differential-cuda 3.12% <0.00%> (?)
total 29.13% <ø> (-0.02%) ⬇️ Carriedforward from 74f6779

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vish0012
Please fill "How was this PR tested?". You need to check this PR by running autoware.
Please fill "Interface changes"

@yukkysaito
Copy link
Contributor

If the test results are entered and deemed appropriate, I will approve.

@mitsudome-r
Copy link
Member

@Shin-kyoto Interface info is updated and test is attached in above comment.

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • I confirm that the content is good to merge and the test result shows this PR is properly tested to ensure it will not introduce any bugs.
  • I did NOT check this PR by running autoware.

@mitsudome-r
Copy link
Member

I have tested the PR with AWSIM and confirmed that the topic types were updated.
image

@mitsudome-r mitsudome-r merged commit 789d5c0 into autowarefoundation:main Jan 23, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants