-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_euclidean_cluster)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_euclidean_cluster #9873
Conversation
…es perception/autoware_euclidean_cluster Signed-off-by: vish0012 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9873 +/- ##
==========================================
- Coverage 29.14% 29.12% -0.02%
==========================================
Files 1423 1426 +3
Lines 107820 107828 +8
Branches 42236 42246 +10
==========================================
- Hits 31420 31406 -14
- Misses 73358 73379 +21
- Partials 3042 3043 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vish0012
Please fill "How was this PR tested?". You need to check this PR by running autoware.
Please fill "Interface changes"
If the test results are entered and deemed appropriate, I will approve. |
@Shin-kyoto Interface info is updated and test is attached in above comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- I confirm that the content is good to merge and the test result shows this PR is properly tested to ensure it will not introduce any bugs.
- I did NOT check this PR by running autoware.
Description
The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.
Related links
Parent Issue:
XXXStamped
messages from tier4_autoware_msgs to autoware_internal_msgs autoware#5580How was this PR tested?
Test are done in the following TIER IV internal evaluator:
https://evaluation.ci.tier4.jp/evaluation/reports/bfc0e074-207b-5ece-83e5-fb769f6f7272?project_id=prd_jt
https://evaluation.ci.tier4.jp/evaluation/reports/4df9332b-024e-5907-ada9-fbbcb8c20b3d?project_id=prd_jt
https://evaluation.ci.tier4.jp/evaluation/reports/ce1a0892-d8aa-5729-b25d-6d2d57bea034?project_id=prd_jt
Notes for reviewers
None.
Interface changes
Modifications
Same modification made to both euclidean cluster and voxel grid based euclidean cluster nodes.
debug/cyclic_time_ms
tier4_debug_msgs/Float64Stamped
autoware_internal_debug_msgs/Float64Stamped
debug/processing_time_ms
tier4_debug_msgs/Float64Stamped
autoware_internal_debug_msgs/Float64Stamped
debug/pipeline_latency_ms
tier4_debug_msgs/Float64Stamped
autoware_internal_debug_msgs/Float64Stamped
Effects on system behavior
None.