Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_geography_utils): fix cppcheck-differential errors #108

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 6, 2024

Description

This PR added the minimal .cppcheck_suppressions to pass the cppcheck-differential.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@youtalk youtalk self-assigned this Dec 6, 2024
@youtalk youtalk changed the title feat(autoware_geography_utils): fix cppcheck-differential errors fix(autoware_geography_utils): fix cppcheck-differential errors Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk force-pushed the fix-cppcheck-error branch from 2f0c4b3 to 0214ce8 Compare December 6, 2024 05:36
@youtalk youtalk marked this pull request as ready for review December 6, 2024 05:40
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I was just trying to fix it.

@youtalk youtalk merged commit f3f82cb into main Dec 6, 2024
32 checks passed
@youtalk youtalk deleted the fix-cppcheck-error branch December 6, 2024 05:43
@youtalk
Copy link
Member Author

youtalk commented Dec 6, 2024

@mitsudome-r Could you add the cppcheck-differential as a required CI check?

@youtalk
Copy link
Member Author

youtalk commented Dec 6, 2024

@mitsudome-r Could you also add the clang-tidy-differential as a required CI check?
https://github.com/autowarefoundation/autoware.core/actions/runs/12193634518/job/34016236032

@mitsudome-r
Copy link
Member

@youtalk They are added now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants