feat: add AMQP 0-9-1 support #456
Conversation
AceTheCreator
requested review from
fmvilas,
Souvikns,
KhudaDad414 and
asyncapi-bot-eve
as code owners
src/adapters/amqp/index.ts
Outdated
| keepalive: serverBindings?.keepAlive || 0, | ||
| vhost: serverBindings?.vhost || '/', |
There was a problem hiding this comment.
I don't think we have these properties in server binding(or any server bindings for that matter). 🤔
https://github.com/asyncapi/bindings/tree/master/amqp
There was a problem hiding this comment.
Yea, we don't. I was playing around trying a default connection. I'll definitely get rid of it
src/adapters/amqp/index.ts
Outdated
|
|
||
|
|
||
| async _connect(): Promise<this> { | ||
| const resolved = false |
There was a problem hiding this comment.
I don't see the point of this variable.
src/adapters/amqp/index.ts
Outdated
| vhost: serverBindings?.vhost || '/', | ||
| heartbeat: serverBindings?.heartbeat || 0, | ||
| protocolVersion, | ||
| } as any) |
There was a problem hiding this comment.
any reason we supressing typescript typechecking here?
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 5326088969
💛 - Coveralls |
|
@KhudaDad414 i updated this PR, have a look |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
this issue will be included as a feature after we release the v1 of glee. supporting a new protocol isn't the priority for now. |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
This PR adds support for AMQP 0-9-1.
cc @fmvilas @Souvikns @KhudaDad414
fixes: #257