-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AMQP 1.0 #258
Comments
@fmvilas I would like to work on this issue under the GSOC tag. I want to discuss some of the things which will just clarify my doubts even further. |
Great! Yeah, feel free to ask any questions. I'm happy to answer them :) |
The |
No, since RabbitMQ uses AMQP 0-9-1, this is something to be implemented in #257. |
No, you don't have to but feel free to share as much information as you want. Please, bear in mind we'll decide on the list of candidates by June 6th so I would not work on this in the meantime. |
Hey there 👋 hope everyone's doing great. I was a little bit inactive due to my exams.
Is there anything more I can do then please let me know. |
@fmvilas Is this issue still open for work? |
Absolutely 👍 Would be awesome, actually :) |
I'm kinda stuck on this issue, don't know where to start. Can anyone guide me for the same? |
@atharvagadkari05 I'm happy to guide you. I'll ping you after August 15th, I'm going on holiday now. |
I'm back now, @atharvagadkari05. How can I help you? Where are you stuck? Would be awesome if you can share some code (if you have it) or provide a detailed explanation of why/where are you stuck. Happy to jump on a call if needed. |
Thanks for the reply @fmvilas 👍. I haven't written any code, I was just reading about different protocols (AMQP and its versions). Once I know what to do I can proceed with my work 👍. |
@atharvagadkari05 I'm doing a Glee codebase onboarding session tomorrow at 4 PM CEST. Do you want to join? |
@fmvilas Sure 👍 |
@Souvikns @fmvilas I think I've found the official documentation for the AMQP JavaScript client (Rhea) |
This is not the official rhea docs AFAIK. This is just an RH library making use of rhea if I understood correctly. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
I'm picking this up with @KhudaDad414 permission. |
I don't think that will be necessary, as there's already a PR for it, #456 |
@AceTheCreator amqp 0-9-1 and amqp 1 are two different protocols for some reason. 😆 |
I'm so sorry; I thought it was the same issue 😂 |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Still relevant. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Reason/Context
Currently, Glee only supports WebSockets (server) and MQTT protocols. This means it's unusable for those using Kafka, AMQP, or any other different protocol.
Description
We should add support for AMQP 1.0. In theory, it should be just a matter of adding a new adapter in the
adapters
folder. Beware AMQP 1.0 and AMQP 0-9-1 are totally different protocols, despite having the same name.The text was updated successfully, but these errors were encountered: