Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load DAGs from DB if not available locally #63

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Conversation

fritz-astronomer
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (de68415) 41.28% compared to head (30db89f) 41.66%.
Report is 1 commits behind head on main.

Files Patch % Lines
...starship/starship/services/local_airflow_client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   41.28%   41.66%   +0.38%     
==========================================
  Files          16       16              
  Lines        1153     1152       -1     
==========================================
+ Hits          476      480       +4     
+ Misses        677      672       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-astronomer
Copy link
Contributor

I'd like to bump this and see if we can get it merged and released! TY.

@fritz-astronomer fritz-astronomer changed the title Load DAGs from DB if not available locally [CSE-1101] Load DAGs from DB if not available locally Nov 17, 2023
Copy link

Starship DAGBag Issue

@alex-astronomer
Copy link
Contributor

Actually, this needs some small changes. On Astro, when DAG deploys are enabled the dags folder is almost empty, but the Astronomer monitoring DAG still exists on the webserver in some cases. Instead of running read_dags_from_db when there are no DAGs in the DAGBag, we should just run this by default, because that's how the webserver normally handles anyway.

@alex-astronomer alex-astronomer self-requested a review November 17, 2023 18:42
@fritz-astronomer
Copy link
Contributor Author

@alex-astronomer I apologize that I don't remember more specifics, but I feel like there was some issue and why I didn't default to it. Maybe this functionality doesn't exist or was buggy on some airflows or some airflow versions?

@fritz-astronomer fritz-astronomer added this to the Starship 2.0 milestone Dec 6, 2023
@fritz-astronomer fritz-astronomer self-assigned this Dec 8, 2023
@fritz-astronomer fritz-astronomer changed the base branch from main to dev December 26, 2023 18:29
@fritz-astronomer fritz-astronomer changed the title [CSE-1101] Load DAGs from DB if not available locally Load DAGs from DB if not available locally Dec 26, 2023
@fritz-astronomer fritz-astronomer merged commit f33ff85 into dev Dec 26, 2023
5 of 6 checks passed
@fritz-astronomer fritz-astronomer deleted the gcc_compat branch December 26, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants