Getting DAGs Uses SerializedDAG instead of DagBag #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a case on Astro where the webserver didn't have any DAGs in the container's
dagsdirectory. Airflow 2.0 introduced Serialized DAGs which keep the webserver stateless and offload the parsing process to the scheduler. This also keeps the webserver more lightweight.When we get DAGs for the DAGs Cutover view, it used the DagBag which pulls DAGs locally, however when there are no DAGs in the webserver, this returns no results.
This PR changes
get_dagsin the local client to useSerializedDagModel.read_all_dags()in order to pick up DAGs that are parsed and serialized.I also changed
CONTRIBUTING.mdto use theDOCKER_BUILDKIT=1argument, which I needed when building locally.