Skip to content

fix(focus_follows_mouse): don't reset g_window_manager.ffm_mode when it is called without a corresponding MENU_OPENED #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnko wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(focus_follows_mouse): don't reset g_window_manager.ffm_mode when it is called without a corresponding MENU_OPENED #2740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e6a456
fix(focus_follows_mouse): don't reset g_window_manager.ffm_mode when …
johnko Jan 26, 2026
deb9523
add to CHANGELOG.md
johnko Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Changed
- Update scripting addition for macOS 26.2 Apple Silicon [#2693](https://github.com/asmvik/yabai/issues/2693)
- Fix window sub-level query for macOS 26 [#2726](https://github.com/asmvik/yabai/issues/2726)
- Fix focus_follows_mouse where MENU_CLOSED was resetting ffm_mode when called without a corresponding MENU_OPENED [#2740](https://github.com/asmvik/yabai/pull/2740)

## [7.1.16] - 2025-10-07
### Changed
Expand Down
6 changes: 3 additions & 3 deletions src/event_loop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1535,10 +1535,10 @@ static EVENT_HANDLER(MENU_CLOSED)
--is_menu_open;

if (is_menu_open < 0) {
// Sometimes Chrome apps call MENU_CLOSED without a corresponding MENU_OPENED,
// so just reset the `is_menu_open` and don't reset the FFM mode.
is_menu_open = 0;
}

if (is_menu_open == 0) {
} else if (is_menu_open == 0) {
g_window_manager.ffm_mode = ffm_value;
}
}
Expand Down