fix(focus_follows_mouse): don't reset g_window_manager.ffm_mode when it is called without a corresponding MENU_OPENED#2740
Open
johnko wants to merge 2 commits intoasmvik:masterfrom
Conversation
…it is called without a corresponding MENU_OPENED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i observed these logs when running
yabai --verbose:so i think MENU_CLOSED is being called without MENU_OPENED, which leaves
ffm_valueenum default to FFM_DISABLED.This patch just avoids setting
g_window_manager.ffm_modeifis_menu_openwas negative because that means it was probably called without a corresponding MENU_OPENED.(Alternatively, another fix could be saving
ffm_value = g_window_manager.ffm_modeearlier than just inEVENT_HANDLER(MENU_OPENED))fixes #2217