Skip to content

map_region use huge page #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bullhh wants to merge 1 commit into from
Closed

map_region use huge page #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/address_space/backend/alloc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl<H: PagingHandler> Backend<H> {
|_va| PhysAddr::from(0),
size,
MappingFlags::empty(),
false,
true,
Copy link
Copy Markdown
Contributor

@hky1999 hky1999 Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok to use 2MB paging in map_linear

BUT in map_alloc, how to handle 2MB page fault for mappings without populated flag?

I believe that there is a way, BUT not well supported in current page_table_multiarch

Copy link
Copy Markdown
Contributor

@aarkegz aarkegz Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I think a co-design is necessary.

false,
)
.is_ok()
Expand Down
2 changes: 1 addition & 1 deletion src/address_space/backend/linear.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ impl<H: PagingHandler> Backend<H> {
|va| PhysAddr::from(va.as_usize() - pa_va_offset),
size,
flags,
false,
true,
false,
)
.is_ok()
Expand Down