Closed
Conversation
bullhh
requested review from
aarkegz,
hky1999,
shilei-massclouds and
yfblock
hky1999
reviewed
Sep 28, 2025
| size, | ||
| MappingFlags::empty(), | ||
| false, | ||
| true, |
Contributor
There was a problem hiding this comment.
It is ok to use 2MB paging in map_linear
BUT in map_alloc, how to handle 2MB page fault for mappings without populated flag?
I believe that there is a way, BUT not well supported in current page_table_multiarch
Contributor
There was a problem hiding this comment.
Agree. I think a co-design is necessary.
shilei-massclouds
left a comment
shilei-massclouds
left a comment
There was a problem hiding this comment.
如hky说的那个关于populated 的问题，咱们提交的修改还是尽量考虑覆盖之前的不同情况；如果有目前确实不易处理的分支情况，至少先暂时给出个临时的处理方式，后续在逐步解决。另外，提交时最好还是写一下总的意图和想法，或者给一个指向Issue的链接。
Author
|
后期周睿将会对内存进行重构一并解决该问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.