Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

aragon / osx Public

Notifications You must be signed in to change notification settings
Fork 43
Star 85

Code
Issues 2
Pull requests 8
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use common mocks and token calls generators #527

Merged

josemarinas merged 9 commits into develop from f/OS-999-use-common-mocks

Feb 16, 2024

Merged

feat: use common mocks and token calls generators #527

josemarinas merged 9 commits into develop from f/OS-999-use-common-mocks

Feb 16, 2024

Conversation 30 Commits 9 Checks 21 Files changed

Conversation

Copy link

Contributor

josemarinas commented Jan 31, 2024 •

edited by jira bot

Loading

Description

Use createDummyAction and Token calls generator from the @aragon/osx-commons-subgraph

Task ID: OS-999

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

I have selected the correct base branch.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
My changes generate no new warnings.
Any dependent changes have been merged and published in downstream modules.
I ran all tests with success and extended them if necessary.
I have updated the CHANGELOG.md file in the root folder.
I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
I have updated the UPDATE_CHECKLIST file in the root folder.

Sorry, something went wrong.

All reactions

github-actions bot added the subgraph label

josemarinas requested review from Rekard0 and heueristik

January 31, 2024 15:23

heueristik reviewed

View reviewed changes

packages/subgraph/CHANGELOG.md Outdated Show resolved Hide resolved

heueristik reviewed

View reviewed changes

packages/subgraph/tests/admin/admin.test.ts Outdated Show resolved Hide resolved

heueristik reviewed

View reviewed changes

packages/subgraph/tests/helpers/method-classes.ts Outdated Show resolved Hide resolved

heueristik reviewed

View reviewed changes

packages/subgraph/tests/helpers/method-classes.ts Outdated Show resolved Hide resolved

heueristik reviewed

View reviewed changes

Copy link

Contributor

heueristik left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've left some minor comments.

Thanks for removing the redundant imports along the way.
Let's also remove redundant code/comments where we see them.

Sorry, something went wrong.

jordaniza reacted with thumbs up emoji

All reactions

👍 1 reaction

heueristik reviewed

View reviewed changes

packages/subgraph/tests/helpers/method-classes.ts Outdated Show resolved Hide resolved

heueristik reviewed

View reviewed changes

packages/subgraph/tests/helpers/method-classes.ts Show resolved Hide resolved

heueristik previously approved these changes

View reviewed changes

Copy link

Contributor

heueristik commented Feb 1, 2024

One typo left

All reactions

Sorry, something went wrong.

josemarinas dismissed heueristik’s stale review via

da36cd2

February 1, 2024 16:28

josemarinas force-pushed the f/OS-999-use-common-mocks branch from 63d8918 to f7ac8f5 Compare

February 2, 2024 09:36

Rekard0 reviewed

View reviewed changes

packages/subgraph/tests/dao/dao_v1_0_0.test.ts Outdated Show resolved Hide resolved

Rekard0 reviewed

View reviewed changes

packages/subgraph/tests/addresslist-voting/addresslist-voting.test.ts Outdated Show resolved Hide resolved

Rekard0 reviewed

View reviewed changes

packages/subgraph/CHANGELOG.md Outdated Show resolved Hide resolved

jordaniza reviewed

View reviewed changes

Copy link

jordaniza left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly echo the comments from Sarkawt. Added some minor other comments

Sorry, something went wrong.

All reactions

packages/subgraph/tests/admin/admin.test.ts Outdated Show resolved Hide resolved

packages/subgraph/tests/dao/dao_v1_3_0.test.ts Outdated Show resolved Hide resolved

josemarinas added 2 commits

February 6, 2024 09:19


          update commons version

d331e28

wip

6cd19e0

josemarinas force-pushed the f/OS-999-use-common-mocks branch from f7ac8f5 to 6cd19e0 Compare

February 6, 2024 08:19

josemarinas added 3 commits

February 6, 2024 09:24


          minor fix

62a9756


          fix comments

070c496


          fix prettier

b279668

Rekard0 reviewed

View reviewed changes

packages/subgraph/tests/dao/dao_v1_3_0.test.ts Show resolved Hide resolved


          fix comments

cfbdb16

josemarinas requested review from Rekard0, heueristik and jordaniza

February 12, 2024 14:21

jordaniza previously approved these changes

View reviewed changes

Copy link

jordaniza left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move to avoiding use of magic numbers and repeated names over time but other than that the PR looks good from what I can see.

Sorry, something went wrong.

All reactions

packages/subgraph/tests/dao/dao_v1_3_0.test.ts Show resolved Hide resolved


          add global constants

josemarinas dismissed jordaniza’s stale review via

February 14, 2024 08:48

Rekard0 previously approved these changes

View reviewed changes

heueristik suggested changes

View reviewed changes

Copy link

Contributor

heueristik left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflict in the yarn.lock file

Sorry, something went wrong.

All reactions

yarn.lock Outdated Show resolved Hide resolved

heueristik reviewed

View reviewed changes

packages/subgraph/CHANGELOG.md Outdated Show resolved Hide resolved


          fix yarn lock and update changelog

5382eaf

josemarinas dismissed Rekard0’s stale review via

5382eaf

February 16, 2024 10:51

jordaniza reviewed

View reviewed changes

packages/subgraph/tests/dao/dao_v1_0_0.test.ts Outdated Show resolved Hide resolved


          add constants to dao v1 tests

2ce2430

jordaniza approved these changes

View reviewed changes

Copy link

jordaniza left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

All reactions

heueristik approved these changes

View reviewed changes

josemarinas merged commit 1f4aa06 into develop

16 checks passed

josemarinas deleted the f/OS-999-use-common-mocks branch

February 16, 2024 14:18

clauBv23 mentioned this pull request

feat: define the develop and main branch to run the actions on commit aragon/osx-commons#71

Merged

8 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jordaniza jordaniza approved these changes

heueristik heueristik approved these changes

Rekard0 Rekard0 left review comments

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.