-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: define the develop and main branch to run the actions on commit #71
feat: define the develop and main branch to run the actions on commit #71
Conversation
…s and run them also on PR relevant changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong but this wont trigger on prs
nevermind, I think we are ok |
just fyi @Rekard0 , this reverts the changes on https://github.com/aragon/osx-commons/pull/63/files We deleted the restrictions so we tested that changes on one packages does not break the other ones, this addresses this by testing everything on |
Co-authored-by: Rekard0 <[email protected]>
317bccf
The changes on that PR were done due to actions being triggered on changes on commits, not on PRs (on This PR is not reverting the changes made on PR #63. In the current approach, the modifications made on the defined path are scoped to the entire PR, not a single commit as was being done.
Regarding this part, this repo packages are not related directly but through npm package dependencies. I mean, we have four packages: contracts, SDK, subgraph, and config, and their dependencies are defined in the respective The only packages that are directly related are the subgraph and the contracts because the subgraph needs the contracts abi and that is already managed |
Description
Changes addressed on this PR:
Task ID: OS-1134
Checklist:
CHANGELOG.md
file in the root folder.