Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy(contracts): corrects managing DAO proposal formatting #519

Merged
merged 3 commits into from
Jan 10, 2024
Merged

deploy(contracts): corrects managing DAO proposal formatting #519

merged 3 commits into from
Jan 10, 2024

Conversation

mathewmeconry
Copy link
Contributor

@mathewmeconry mathewmeconry commented Jan 4, 2024 •
edited
Loading

Description

corrects managing DAO proposal formatting to be displayed properly by the UI

image

Task ID: OS-927

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

Rekard0
Rekard0 previously approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
It would be nice to see an example proposal on a test DAO so we see how it look like for QA.

@mathewmeconry mathewmeconry merged commit 1dd8963 into develop Jan 10, 2024
@mathewmeconry mathewmeconry deleted the OS-927-improve-formating-of-proposal-description branch January 10, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewmeconry @Rekard0 @heueristik