Skip to content

Commit 8bd7abe

Browse files
committed
deploy(contracts): improves upgrade 1.3.0 readability
1 parent e521064 commit 8bd7abe

11 files changed

+12
-12
lines changed

packages/contracts/deploy/update/to_v1.3.0/10_DAOFactory.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
6060
to: managingDAOAddress,
6161
value: 0,
6262
data: calldata,
63-
description: `Moves the REGISTER_DAO_PERMISSION_ID permission on the DAORegistry (${daoRegistryAddress}) from the old to the new DAOFactory (${previousDAOFactoryAddress} -> ${deployResult.address}).`,
63+
description: `Moves the <strong>REGISTER_DAO_PERMISSION_ID</strong> permission on the <strong>DAORegistry</strong> (<code>${daoRegistryAddress}</code>) from the old <strong>DAOFactory</strong> (<code>${previousDAOFactoryAddress}</code>) to the new <strong>DAOFactory</strong> (<code>${deployResult.address}</code>).`,
6464
});
6565
};
6666
export default func;

packages/contracts/deploy/update/to_v1.3.0/20_PluginRepoFactory.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
6060
to: managingDAOAddress,
6161
value: 0,
6262
data: calldata,
63-
description: `Moves the REGISTER_PLUGIN_REPO_PERMISSION permission on the PluginRepoRegistry (${pluginRepoRegistryAddress}) from the old to the new PluginRepoFactory (${previousPluginRepoFactoryAddress} -> ${deployResult.address}).`,
63+
description: `Moves the <strong>REGISTER_PLUGIN_REPO_PERMISSION</strong> permission on the <strong>PluginRepoRegistry</strong> (<code>${pluginRepoRegistryAddress}</code>) from the old <strong>PluginRepoFactory</strong> (<code>${previousPluginRepoFactoryAddress}</code>) to the new <strong>PluginRepoFactory</strong> (<code>${deployResult.address}</code>).`,
6464
});
6565
};
6666
export default func;

packages/contracts/deploy/update/to_v1.3.0/30_Multisig_PluginRepo.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
4040
to: upgradeTX.to,
4141
data: upgradeTX.data,
4242
value: 0,
43-
description: `Upgrade the "multisig-repo" PluginRepo (${multisigPluginRepoAddress}) to the new implementation (${newPluginRepoImplementation})`,
43+
description: `Upgrade the <strong>Multisig PluginRepo</strong> (<code>${multisigPluginRepoAddress}</code>) to the new <strong>implementation</strong> (<code>${newPluginRepoImplementation}</code>).`,
4444
});
4545
};
4646
export default func;

packages/contracts/deploy/update/to_v1.3.0/31_Multisig_Plugin.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
7979
to: tx.to,
8080
data: tx.data,
8181
value: 0,
82-
description: `Creates a new build for release 1 in the MultisigRepo (${multisigRepoAddress}) with MultisigSetup (${deployResult.address})`,
82+
description: `Creates a new build for release 1 in the <strong>Multisig PluginRepo</strong> (<code>${multisigRepoAddress}</code>) with <strong>MultisigSetup</strong> (<code>${deployResult.address}</code>).`,
8383
});
8484
};
8585
export default func;

packages/contracts/deploy/update/to_v1.3.0/40_TokenVoting_PluginRepo.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
4040
to: upgradeTX.to,
4141
data: upgradeTX.data,
4242
value: 0,
43-
description: `Upgrade the "token-voting-repo" PluginRepo (${tokenVotingPluginRepoAddress}) to the new implementation (${newPluginRepoImplementation})`,
43+
description: `Upgrade the <strong>TokenVoting PluginRepo</strong> (<code>${tokenVotingPluginRepoAddress}</code>) to the new <strong>implementation</strong> (<code>${newPluginRepoImplementation}</code>).`,
4444
});
4545
};
4646
export default func;

packages/contracts/deploy/update/to_v1.3.0/41_TokenVoting_Plugin.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
116116
to: tx.to,
117117
data: tx.data,
118118
value: 0,
119-
description: `Creates a new build for release 1 in the TokenVotingRepo (${tokenVotingRepoAddress}) with TokenVotingSetup (${deployResult.address})`,
119+
description: `Creates a new build for release 1 in the <strong>TokenVoting PluginRepo</strong> (<code>${tokenVotingRepoAddress}</code>) with <strong>TokenVotingSetup</strong> (<code>${deployResult.address}</code>).`,
120120
});
121121
};
122122
export default func;

packages/contracts/deploy/update/to_v1.3.0/50_AddresslistVoting_PluginRepo.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
4141
to: upgradeTX.to,
4242
data: upgradeTX.data,
4343
value: 0,
44-
description: `Upgrade the "address-list-voting-repo" (${addresslistVotingPluginRepoAddress}) PluginRepo to the new implementation (${newPluginRepoImplementation})`,
44+
description: `Upgrade the <strong>Addresslist PluginRepo</strong> (<code>${addresslistVotingPluginRepoAddress}</code>) to the new <strong>implementation</strong> (<code>${newPluginRepoImplementation}</code>).`,
4545
});
4646
};
4747
export default func;

packages/contracts/deploy/update/to_v1.3.0/51_AddresslistVoting_Plugin.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
8484
to: tx.to,
8585
data: tx.data,
8686
value: 0,
87-
description: `Creates a new build for release 1 in the AddresslistVotingRepo (${addresslistVotingRepoAddress}) with AddresslistVotingSetup (${deployResult.address})`,
87+
description: `Creates a new build for release 1 in the <strong>AddresslistVoting PluginRepo</strong> (<code>${addresslistVotingRepoAddress}</code>) with <strong>AddresslistVotingSetup</strong> (<code>${deployResult.address}</code>).`,
8888
});
8989
};
9090
export default func;

packages/contracts/deploy/update/to_v1.3.0/60_Admin_PluginRepo.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
3737
to: upgradeTX.to,
3838
data: upgradeTX.data,
3939
value: 0,
40-
description: `Upgrade the "admin-repo" PluginRepo (${adminPluginRepoAddress}) to the new implementation (${newPluginRepoImplementation})`,
40+
description: `Upgrade the <strong>Admin PluginRepo</strong> (<code>${adminPluginRepoAddress}</code>) to the new <strong>implementation</strong> (<code>${newPluginRepoImplementation}</code>).`,
4141
});
4242
};
4343
export default func;

packages/contracts/deploy/update/to_v1.3.0/90_ManagingDAO.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
3333
to: upgradeTX.to,
3434
data: upgradeTX.data,
3535
value: 0,
36-
description: `Upgrade the managing DAO to the new implementation (${newDaoImplementation})`,
36+
description: `Upgrade the <strong>management DAO</strong> (<code>${managingDAOAddress}</code>) to the new <strong>implementation</strong> (<code>${newDaoImplementation}</code>).`,
3737
});
3838
};
3939
export default func;

packages/contracts/deploy/verification/99_conclude/01_managing_dao_proposal.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
2323
await managingDAOMultisig.callStatic.multisigSettings();
2424

2525
const proposalDescription = hre.managingDAOActions
26-
.map(action => `<p>${action.description}</p>`)
26+
.map(action => `<li>${action.description}</li>`)
2727
.join('');
2828
const cid = await uploadToIPFS(
2929
JSON.stringify({
3030
title: 'Framework Upgrade 1.3.0',
3131
summary: `This proposal upgrades the framework on ${network.name} to the 1.3.0 version`,
32-
description: proposalDescription,
32+
description: `<ul>${proposalDescription}</ul>`,
3333
resources: [],
3434
}),
3535
network.name

0 commit comments

Comments
 (0)