test: Enable skipped test related to Autocomplete #36991
Conversation
NandanAnantharamu
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
WalkthroughThe pull request introduces modifications to the Cypress test suite for JavaScript autocomplete functionality. It activates a previously skipped test case related to Bug #15429, ensuring that random keystrokes triggering autocomplete suggestions are now tested. Additionally, the path for the test specification in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/ci-test-limit-count run_count=25 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11437028886. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/client/cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts (1)
Line range hint
114-186: Improve test case implementation for Bug #15429The test case for Bug #15429 has been unskipped, which is good for increasing test coverage. However, there are a few areas for improvement:
- Remove
agHelper.Sleep()calls as they are against the coding guidelines. Use Cypress's built-in waiting mechanisms instead.- Use data-* attributes for selectors instead of relying on class names or element types.
- Avoid using string literals for assertions. Consider using constants or enums for expected values.
Here's an example of how you could refactor a part of the test:
const NO_HINTS_MESSAGE = "No autocomplete hints should be present"; // Instead of: agHelper.AssertElementAbsence(locators._hints); // Use: cy.get('[data-cy="autocomplete-hints"]').should('not.exist').then(() => { cy.log(NO_HINTS_MESSAGE); });This approach improves readability and maintainability of the test case.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
- app/client/cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts (1 hunks)
- app/client/cypress/limited-tests.txt (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
app/client/cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts (1)
Pattern
app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/limited-tests.txt (1)
Pattern
app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🔇 Additional comments (1)
app/client/cypress/limited-tests.txt (1)
2-2: LGTM. Verify the new test specification.The change aligns with the PR objectives. Ensure that the new test specification
JS_AC2_spec.tsincludes the activated test case for Bug #15429.✅ Verification successful
File
app/client/cypress/limited-tests.txtVerification FailedThe new test specification file
cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.tsdoes not exist.
- Action Required:
- Verify the correct path of the new test specification.
- Ensure that the file has been added to the repository.
Verify
JS_AC2_spec.tsIncludes Test for Bug #15429
- Action Required:
- Ensure that the test case for Bug [Bug]-[350]:Random keystrokes trigger autocomplete to show up #15429 is present in the file.
Test Specification for Bug #15429 Verified
- The test case for Bug [Bug]-[350]:Random keystrokes trigger autocomplete to show up #15429 is present in
cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the content of the new test specification rg -A 10 "Bug #15429" "cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts"Length of output: 187
Script:
#!/bin/bash # Search for the JS_AC2_spec.ts file in the repository fd "JS_AC2_spec.ts"Length of output: 92
Script:
#!/bin/bash # Verify the presence of "Bug #15429" in the test specification rg "Bug #15429" "app/client/cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts"Length of output: 170
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11437028886. |
NandanAnantharamu
changed the title
github-actions
bot
added
skip-changelog
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5409
/ok-to-test tags="@tag.Sanity"
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11474508904
Commit: 79acd59
Cypress dashboard.
Tags:
@tag.SanitySpec:
Wed, 23 Oct 2024 08:03:14 UTC