Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isRequired validation property for table select column #36375

Merged
merged 20 commits into from
Sep 23, 2024
Merged

fix: isRequired validation property for table select column #36375

merged 20 commits into from
Sep 23, 2024

Commits on Jul 4, 2024

  1. fix: add regex check on phone number change

    @SaiCharanChetpelly31
    SaiCharanChetpelly31 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    b0963bb View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. feat: add comment for regex in phone input widget

    @SaiCharanChetpelly31
    SaiCharanChetpelly31 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ed41946 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release' of https://github.com/SaiCharanChetpelly31/app… 

    …smith into fix/Issue_25911_onTextChanged_phone_input_widget
    @SaiCharanChetpelly31
    SaiCharanChetpelly31 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    beea37b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. add validation in derived.js and SelectCell with isEditableCellValid

    @jacquesikot
    jacquesikot committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6c823bf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release' of https://github.com/appsmithorg/appsmith int… 

    …o fix/validation-and-required-property-for-table-select-column
    @jacquesikot
    jacquesikot committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    440ec7f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. allow validation in select column property + pass hasError prop in Se… 

    …lectComponent
    @jacquesikot
    jacquesikot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0ff1bac View commit details
    Browse the repository at this point in the history

  2. remove overriding css

    Pawan Kumar authored and Pawan Kumar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    eceeb49 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. add cypress test cases

    @jacquesikot
    jacquesikot committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    886c248 View commit details
    Browse the repository at this point in the history

  2. set only isRequired validation for table select column

    @jacquesikot
    jacquesikot committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9ef6228 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release' of https://github.com/appsmithorg/appsmith int… 

    …o fix/validation-and-required-property-for-table-select-column
    @jacquesikot
    jacquesikot committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    079c0ee View commit details
    Browse the repository at this point in the history

  4. rename test file for clarity

    @jacquesikot
    jacquesikot committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3aed3c0 View commit details
    Browse the repository at this point in the history

  5. revert spacing change in index.styled

    @jacquesikot
    jacquesikot committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    01cfe05 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'release' of https://github.com/appsmithorg/appsmith int… 

    …o fix/validation-and-required-property-for-table-select-column
    @jacquesikot
    jacquesikot committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9545e07 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. fix selectors in Table_select_validation_spec

    @jacquesikot
    jacquesikot committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6bb7b5a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. abstract hideColumnByType to function + improve Table_select_validati… 

    …on_spec
    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    02d8949 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release' of https://github.com/appsmithorg/appsmith int… 

    …o fix/validation-and-required-property-for-table-select-column
    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    64f8576 View commit details
    Browse the repository at this point in the history

  3. remove .only from test

    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    110e6fd View commit details
    Browse the repository at this point in the history

  4. remove reducndant check for border color in Table_select_validation_spec

    @jacquesikot
    jacquesikot committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8a38ded View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. add const for select error and valid style

    @jacquesikot
    jacquesikot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    17f9fbc View commit details
    Browse the repository at this point in the history

  2. replace cy.dragAndDropToCanvas with entityExplorer.DragNDropWidget

    @jacquesikot
    jacquesikot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d2597e6 View commit details
    Browse the repository at this point in the history