fix: isRequired validation property for table select column

[jacquesikot]

Description

Problem
The select column of the table widget does not have a validation property within its property pane to allow users add an isRequired validation to the table select column.

Solution
Added a Validation section to the table select column's property pane, which includes an isRequired toggle. When enabled, this feature will trigger a visual indication (error border colour) around the select widget if a required field is left unselected during "Add new row" or inline editing.

Fixes #30091

Automation

/ok-to-test tags="@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity, @tag.Select"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10957896180
Commit: d2597e6
Cypress dashboard.
Tags: @tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity, @tag.Select
Spec:

---

Fri, 20 Sep 2024 12:23:29 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Introduced end-to-end tests for Select column validation in Table widgets.
  • Enhanced validation logic to support Select column types in the Table widget.
  • Added visual feedback for required Select fields during row addition and inline editing.
  • Improved locator for single-select widget button control to enhance UI interaction.

• Bug Fixes

  • Improved error handling and visual representation for invalid editable Select cells.

• Documentation

  • Updated validation configuration to include Select column types for better usability.

• Refactor

  • Enhanced code clarity for styled components related to Select fields.
  • Modified method to improve versatility in handling table interactions.

[coderabbitai]

Walkthrough

This pull request introduces enhancements to the Table widget's Select column type, focusing on validation features. It includes the addition of end-to-end tests to ensure required field validation, updates to styled components for clearer error handling, and modifications to the component logic to support editable cell validation. Furthermore, it expands the validation configuration to include the Select column type, improving the overall robustness and usability of the Table widget.

Changes

Files	Change Summary
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Table_select_validation_spec.ts	Added end-to-end tests for validating Select column behavior, including required field checks.
app/client/cypress/support/Pages/Table.ts	Modified ClickOnEditIcon method to include isSelectColumn parameter for enhanced functionality.
app/client/src/widgets/SelectWidget/component/index.styled.tsx	Restructured conditional logic for error styling in StyledSingleDropDown for better readability.
app/client/src/widgets/TableWidgetV2/component/cellComponents/SelectCell.tsx	Introduced isEditableCellValid to manage editable cell validity and error states.
app/client/src/widgets/TableWidgetV2/widget/derived.js	Added "select" to validatableColumns array to support validation for Select column types.
app/client/src/widgets/TableWidgetV2/widget/index.tsx	Introduced isEditableCellValid property to enhance validation logic for editable cells.
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Validation.ts	Added ColumnTypes.SELECT to accepted column types for validation configuration.
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Validations/Common.ts	Updated visibility logic to include ColumnTypes.SELECT alongside ColumnTypes.DATE.
app/client/cypress/locators/commonlocators.json	Added new locator for singleSelectWidgetButtonControl to enhance UI interaction capabilities.

Assessment against linked issues

Objective	Addressed	Explanation
Support validation section and required toggle for Select column type (30091)	✅

Possibly related issues

• [Task]: Fix flakiness of app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select1_spec.ts #35563: The changes in this PR enhance the validation logic, which may help address the flakiness of tests related to Select columns.

Possibly related PRs

• feat: Allow table search to include label and value for tables with select column type #36061: Enhances test specifications for the TableV2 component, including functionality for select columns.
• feat: Action redesign: Updating the config for Google sheets plugin to use sections and zones format #36117: Introduces a new property to validate editable cells, relevant to the select column validation tests.
• fix: remove Select key value selects, fix default #36158: Modifies validation configuration for the TableWidgetV2 component to include select column types.
• chore: fix select1 spec #36228: Fixes a test related to the select functionality in a table widget, directly relevant to select column behavior.

Suggested labels

Table Widget V2, Needs Triaging, Production, High

🎉 In the land of tables, a change takes flight,
Select columns now sparkle, with validation so bright!
Tests are in place, errors are clear,
A robust widget for all, bringing users cheer!
With each dropdown choice, confidence grows,
In this world of data, the best surely shows! 🌟

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 17f9fbc and d2597e6.

Files selected for processing (1)

• app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Table_select_validation_spec.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Table_select_validation_spec.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jacquesikot]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10903438831.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36375.
recreate: .