[wasm][2/2] Include WebAssembly SDK checks in PR and main workflows #3332
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/add-pr-wasm-workflow
branch
3 times, most recently
from
b29f4f8 to
5837c84
Compare
Also remove `scripts/install_static_sdk.sh`, which has been replaced by `scripts/install_swift_sdk.sh`.
kateinoigakukun
force-pushed
the
katei/add-pr-wasm-workflow
branch
from
5837c84 to
73706ab
Compare
|
@Lukasa would you mind approving CI job execution? |
|
Done. 👍 |
|
Okay, it passed (except for PR label; I can't even add a label here). Can we merge this into main? @Lukasa |
Lukasa
approved these changes
Aug 11, 2025
|
What's going on with the skipped workflows? Their titles don't appear to be rendering correctly. |
|
@Lukasa Unfortunately, that's the nature of swiftlang/github-workflows reusable workflow. The reusable workflow contains jobs for all platforms, and we selectively activate Wasm SDK platforms, and others are skipped. GitHub Actions doesn't render skipped jobs with matrix well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build check CI for WebAssembly SDK
Motivation:
Add build check CI for WebAssembly SDK
Modifications:
Add Wasm build checks in
main.ymlandpull_request.ymlbased on #3331Extracted from #3159
Result:
Setting up the CI job makes it easier to detect such incompatibility before merging.