Skip to content

Conversation

@scottmarchant
Copy link
Contributor

@scottmarchant scottmarchant commented Oct 22, 2025

Fix Swift for WebAssembly compilation in NIOFoundationCompat.

Motivation:

NIO is a common dependency, and it is important to enable compiling NIO using Swift for WebAssembly. This PR fixes compilation for NIOFoundationCompat.

Modifications:

  • Fix NIOFoundationCompat compilation

Result:

With these changes, the following build commands succeed: ✅

swift build --swift-sdk wasm32-unknown-wasip1-threads --target NIOCore
swift build --swift-sdk wasm32-unknown-wasip1-threads --target NIOFoundationCompat

Context:

This PR is part of a larger effort by PassiveLogic to improve Swift for WebAssembly support

@scottmarchant
Copy link
Contributor Author

@MaxDesiatov @kateinoigakukun in case you're interested, I'm fixing Swift for WebAssembly compilation for NIOCore and NIOFoundationCompat in this PR.

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Oct 23, 2025
@Lukasa
Copy link
Contributor

Lukasa commented Oct 23, 2025

This needs to be updated to the latest main. It may be helpful to get maintainers write access to your PR branches, as that allows me to make catch-up merges to main when a prior PR is merged.

@scottmarchant scottmarchant force-pushed the feat/nioFoundationCompatWASICompilation branch from c99ee33 to bf782d4 Compare October 27, 2025 23:55
@scottmarchant
Copy link
Contributor Author

This needs to be updated to the latest main. It may be helpful to get maintainers write access to your PR branches, as that allows me to make catch-up merges to main when a prior PR is merged.

@Lukasa Ok, this should be rebased on the tip of main now. I'll work on getting you write access to the PR source branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants