fix: Fix compiler error found on latest main that breaks wasip1 (wasm) compilation #3271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick simple fix for compiling NIOCore to wasm using the command
swift build --swift-sdk wasm32-unknown-wasip1-threads --target NIOCore.This fixes all errors for
wasip1, however there are other errors remaining inmainwhen compiling forwasiusing the commandswift build --swift-sdk wasm32-unknown-wasi --target NIOCore. Those issues are out of scope for this PR.Motivation:
I am working to enable wasm compilation for a wide range of repositories which depend on NIOCore. See here for a sneak peak. This change is required to enable compiling several respositories.
Modifications:
.multicastNotSupportedis elided foros(WASI)builds in Channel.swift, however some new code referenced that case without properWASIguards.This modification simply adds the appropriate elision guard to fix wasip1 builds for NIOCore.
Result:
After making this change,
swift build --swift-sdk wasm32-unknown-wasip1-threads --target NIOCorebuilds again (assuming you have the appropriate wasm sdk installed).