-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Add swift wasm CI targets to DataLoader #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add swift wasm CI targets to DataLoader #26
Conversation
…r NIOCore works as expected.
…or the latest swift-nio dependency.
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.8 | |||
| // swift-tools-version:5.10.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, this might be a breaking change for some users of this repository, depending on what swift version they are using. It shouldn't be very hard for anyone to move from Swift 5.8 to Swift 5.10, though.
|
The error for swift 5.8 should pass now that the ci change is merged.
|
Change summary
Added swift wasm as a CI target, to help prevent future breakages to swift wasm builds in DataLoader
Details
Notes
PR Dependencies
The following PR's must be merged before this PR can be merged:
Testing done
Verified new github workflow builds, once required upstream dependencies are patched in swift-nio
See https://github.com/PassiveLogic/DataLoader/actions/runs/15833601501/job/44631947127?pr=1
Remaining work