Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support generate primary and public key for sshd #8002

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

sophon-zt
Copy link
Contributor

@sophon-zt sophon-zt commented Aug 20, 2024

e.g:

config tpl:

{{- $key := sshKeyGen }}
PRIVATE_KEY="{{ $key.PrivateKey }}"
PUBLIC_KEY="{{ $key.PublicKey }}"

cmpd:

  configs:
    - name: sshkey-env
      templateRef: ssh-env-tpl
      injectEnvTo:
        - xxxx

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Aug 20, 2024
@sophon-zt sophon-zt linked an issue Aug 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.61%. Comparing base (400d86d) to head (83f45a7).
Report is 10 commits behind head on main.

Files Patch % Lines
pkg/gotemplate/sshkeygenerator.go 72.72% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8002      +/-   ##
==========================================
+ Coverage   62.55%   62.61%   +0.05%     
==========================================
  Files         324      325       +1     
  Lines       40221    40244      +23     
==========================================
+ Hits        25161    25197      +36     
+ Misses      12762    12753       -9     
+ Partials     2298     2294       -4     
Flag Coverage Δ
unittests 62.61% <73.91%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Aug 20, 2024
@sophon-zt sophon-zt merged commit 83cfbf0 into main Aug 23, 2024
76 checks passed
@sophon-zt sophon-zt deleted the feature/support-generate-sshd-key-issue8000 branch August 23, 2024 06:38
@github-actions github-actions bot added this to the Release 0.9.2 milestone Aug 23, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.9

Copy link

github-actions bot commented Sep 4, 2024

🤖 says: Error cherry-picking.

Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: could not apply 83cfbf0... feat: support generate primary and public key for sshd (#8002)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Copy link

github-actions bot commented Sep 4, 2024

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/10703072257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test area/user-interaction size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] support generate sshd key
5 participants