Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support generate primary and public key for sshd #8001

Closed
wants to merge 2 commits into from

Conversation

sophon-zt
Copy link
Contributor

@sophon-zt sophon-zt commented Aug 19, 2024


{{- $key := sshKeyGen }}
PRIVATE_KEY="{{ $key.PrivateKey }}"
PUBLIC_KEY="{{ $key.PublicKey }}"

@sophon-zt sophon-zt linked an issue Aug 19, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Aug 19, 2024
@apecloud-bot
Copy link
Collaborator

This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/

@sophon-zt sophon-zt marked this pull request as draft August 19, 2024 10:30
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (400d86d) to head (d30bcb9).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/gotemplate/sshkeygenerator.go 72.72% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8001      +/-   ##
==========================================
- Coverage   62.55%   62.54%   -0.02%     
==========================================
  Files         324      325       +1     
  Lines       40221    40244      +23     
==========================================
+ Hits        25161    25170       +9     
- Misses      12762    12772      +10     
- Partials     2298     2302       +4     
Flag Coverage Δ
unittests 62.54% <73.91%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot
Copy link
Collaborator

This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/

@sophon-zt
Copy link
Contributor Author

related issue: #8002

@sophon-zt sophon-zt closed this Aug 20, 2024
@github-actions github-actions bot added this to the Release 0.9.2 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-interaction size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] support generate sshd key
2 participants