[SPARK-52272][SQL] V2SessionCatalog does not alter schema on Hive Catalog #51007
+199
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
commented
May 24, 2025
| catalogTable.copy( | ||
| properties = finalProperties, schema = schema, owner = owner, comment = comment, | ||
| collation = collation, storage = storage)) | ||
| if (SQLConf.get.getConf(StaticSQLConf.CATALOG_IMPLEMENTATION).equals("hive")) { |
There was a problem hiding this comment.
Note: SessionCatalog (V1) alterTableDataSchema explicitly does not support 'drop column'. https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala#L499
So to avoid regression in InMemoryCatalog, in which alterTable can alter the schema including 'drop column', I make the change only for "hive". Following the config check for CATALOG_IMPLEMENTATION in other parts of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
V2SessionCatalog delegates alterTable to SessionCatalog (V1) alterTable. In the case of "hive", this should be changed to delegate to either alterTable or alterTableDataSchema.
Why are the changes needed?
SessionCatalog has two API's, alterTable and alterTableDataSchema.
alterTable will silently ignore schema changes in Hive implementation (the API Javadoc:
If the underlying implementation does not support altering a certain field, this becomes a no-op.).So for Hive case, V2SessionCatalog needs to delegate schema changes to V1 alterTableDataSchema
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add new test in HiveDDLSuite, verify functionality and which method is called.
Was this patch authored or co-authored using generative AI tooling?
No