[SPARK-52681][SQL] V2SessionCatalog alter table add column warns on HiveCatalog #51372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a warning that nulls out the schema.
In #51007 we decide to use the proper Catalog API alterDataSchema for column changes. However, that one pass in the table.schema (including partition columns) and not the expected table.dataSchema (ie, without partition columns). For reference, the add column command uses table.dataSchema : https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala#L250
Change to use the table.dataSchema
Why are the changes needed?
If we use table.schema, it adds the partition column twice. This triggers a Hive Metastore exception, which causes us to null out the schema.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add unit test