[SPARK-51517][SQL] Support the TIME data type in Hive results #50282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
MaxGekk
requested review from
LuciferYang,
yaooqinn,
beliefer and
dongjoon-hyun
dongjoon-hyun
approved these changes
Mar 15, 2025
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk .
Merged to master for Apache Spark 4.1.0.
kazemaksOG
pushed a commit
to kazemaksOG/spark-custom-scheduler
that referenced
this pull request
Mar 27, 2025
### What changes were proposed in this pull request? In the PR, I propose to modify `HiveResult` to support new data type `TIME`. ### Why are the changes needed? Before the changes, end-to-end SQL tests fail with the error: ```sql select time '16:39:45\t' -- !query schema struct<> -- !query output scala.MatchError (16:39:45,TimeType(6)) (of class scala.Tuple2) ``` ### Does this PR introduce _any_ user-facing change? It fixes the issue. After the changes, it's possible to write `*.sql` over the new data type. ### How was this patch tested? By running new test: ``` $ build/sbt "test:testOnly *HiveResultSuite" $ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z time.sql" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50282 from MaxGekk/time-toHiveResult. Authored-by: Max Gekk <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to modify
HiveResultto support new data typeTIME.Why are the changes needed?
Before the changes, end-to-end SQL tests fail with the error:
Does this PR introduce any user-facing change?
It fixes the issue. After the changes, it's possible to write
*.sqlover the new data type.How was this patch tested?
By running new test:
Was this patch authored or co-authored using generative AI tooling?
No.