[SPARK-51414][SQL] Add the make_time() function

[robreeves]

What changes were proposed in this pull request?

This adds a new function make_time for the new time datatype. A new function MakeTime is added and some logic was refactored out of MakeTimestamp to be shared with the new function.

Why are the changes needed?

This is needed to create time data type objects.

Does this PR introduce any user-facing change?

Yes, a new function make_time is added.

How was this patch tested?

New unit tests and manually spark-shell testing.

Was this patch authored or co-authored using generative AI tooling?

No

[robreeves]

@MaxGekk this is ready for review

[robreeves]

These test failures don't look related to my changes. I'm rerunning them.

[MaxGekk]

This test failure will be fixed by #50282

[info] - check outputs of expression examples *** FAILED *** (9 seconds, 272 milliseconds)
...
[info]   Cause: scala.MatchError: (06:30:45.887,TimeType(6)) (of class scala.Tuple2)
[info]   at org.apache.spark.sql.execution.HiveResult$.toHiveString(HiveResult.scala:111)

[robreeves]

@MaxGekk this is ready for review again

[MaxGekk]

@robreeves Could you add a couple of end-to-end tests to

spark/sql/core/src/test/resources/sql-tests/inputs/time.sql

Lines 1 to 20 in adc42b4

	-- time literals, functions and operations
	create temporary view time_view as select '11:53:26.038344' time_str, 'HH:mm:ss.SSSSSS' fmt_str;
	select time '16:39:45\t';
	select to_time(null), to_time('01:02:03'), to_time('23-59-59.999999', 'HH-mm-ss.SSSSSS');
	select to_time(time_str, fmt_str) from time_view;
	-- missing fields in `to_time`
	select to_time("11", "HH");
	-- invalid: there is no 13 hours
	select to_time("13-60", "HH-mm");
	select try_to_time(null), try_to_time('00:12:00'), try_to_time('01:02:03', 'HH:mm:ss');
	select try_to_time(1);
	select try_to_time('12:48:31 abc');
	select try_to_time('10:11:12.', 'HH:mm:ss.SSSSSS');
	select try_to_time("02-69", "HH-mm");
	select try_to_time('11:12:13', 'HH:mm:ss', 'SSSSSS');

LGTM in general. Please, resolve conflicts.

[MaxGekk]

+1, LGTM. Merging to master.
Thank you, @robreeves.

[MaxGekk]

@robreeves Congratulations with your first contribution to Apache Spark!

[robreeves]

@MaxGekk thanks for the reviews! This wasn't my first contribution to Spark, but was my first change in the SQL layer.

[MaxGekk]

@robreeves There is a list of contributors of Apache Spark in JIRA. You wasn't in the list for some reasons (I guess, a previous committer forgot to add you). Now you are in the list.