-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bump protobuf.version from 3.25.6 to 4.30.2 #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Are there plans to upgrade |
|
@code4dc Thanks for raising this. This is a decision that's up to the community. I think we should do a Java 8 release with the new types that have recently been added (Variant, Geometry, etc), and then bump to Java 11. |
|
Bumping to 4.30 would really help us out. The new protc version comes with some great features related to field presence tracking. |
Here is a PR for Java 11: #3314 |
|
Just bumping the version won't compile, here is a patch to make it work with protobuf 4. |
|
@uwemaurer Are you interested in filing a PR? |
|
@dependabot rebase |
117256f to
0756ddf
Compare
The getSyntax method on messageDescriptor.getFile() got removed in protobuf version 4. This change gets the syntax information directly from the proto, this works in protobuf v3 and v4. fixes apache#3175 see also apache#3182
|
@dependabot rebase |
0756ddf to
9956775
Compare
|
@dependabot rebase |
Bumps `protobuf.version` from 3.25.6 to 4.30.2. Updates `com.google.protobuf:protobuf-java` from 3.25.6 to 4.30.2 - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](protocolbuffers/protobuf@v3.25.6...v4.30.2) Updates `com.google.protobuf:protobuf-java-util` from 3.25.6 to 4.30.2 --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-java dependency-version: 4.30.2 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: com.google.protobuf:protobuf-java-util dependency-version: 4.30.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
9956775 to
77ed780
Compare
Bumps
protobuf.versionfrom 3.25.6 to 4.30.2.Updates
com.google.protobuf:protobuf-javafrom 3.25.6 to 4.30.2Commits
43e1626Updating version.json and repo version numbers to: 30.27a4c63bFix lite classes in the protobuf-java Maven release to be JDK8 compatible. (#...7831669Remove dllexport attribute on variable definition. (#20833)da9cadcRestore JDK8 compatibility in Bazel for libraries with dependencies from Mave...09b5078Add protobuf_maven artifacts to protobuf_maven_dev as well so they can still ...b7f06f1Add volatile to featuresResolved (#20766)b69f653Restore generator headers in cmake install until the next breaking C++ releas...f4b0a79Restore custom protobuf maven namespaces to avoid polluting main maven namesp...2dc9f35Fix Java concurrency issue in feature resolution for old <=3.25.x gencode usi...221b2a0Change how we decide which empty string implementation to use. (#20708)Updates
com.google.protobuf:protobuf-java-utilfrom 3.25.6 to 4.30.2You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)