GH-3175: support protobuf library version 4 #3352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getSyntax method on messageDescriptor.getFile() got removed in protobuf version 4. This change gets the syntax information directly from the proto, this works in protobuf v3 and v4. fixes apache#3175 see also apache#3182
Fokko
reviewed
Oct 26, 2025
| if ("editions".equals(syntax)) { | ||
| throw new UnsupportedOperationException("protocol buffers 'editions' not supported"); | ||
| } | ||
| boolean isProto2 = !"proto3".equals(syntax); |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to check the versions explicitly, and raise on anything else (for example editions, as above).
Suggested change
| boolean isProto2 = !"proto3".equals(syntax); | |
| boolean isProto2 = "proto2".equals(syntax); |
Contributor
Author
There was a problem hiding this comment.
I wanted to keep the logic the same as in the protobuf library (v4), they have this code:
Edition getEdition() {
switch (proto.getSyntax()) {
case "editions":
return proto.getEdition();
case "proto3":
return Edition.EDITION_PROTO3;
default:
return Edition.EDITION_PROTO2;
}
}
In my tests the value of syntax was an empty string (not "proto2") for proto2 files, this is why it just compares against "editions" and "proto3".
nandorKollar
approved these changes
Nov 4, 2025
|
Thanks for this! Any chances a new release would be prepared anytime soon for this ? |
Contributor
|
Hey @rahul-roy-glean That's a good point! I would recommend reaching out on the dev-list: https://lists.apache.org/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The getSyntax method on messageDescriptor.getFile() got removed in protobuf version 4.
It crashes when a user updates to protobuf 4 and uses the parquet library.
What changes are included in this PR?
This change gets the syntax information directly from the proto, this works in protobuf v3 and v4.
Are these changes tested?
yes, running the existing tests (with protobuf 3).
Are there any user-facing changes?
Closes #3175
Related to #3182