KAFKA-19882: Cleaning client level metric tags #20906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@gensericghiro the failure is related - looks like one test missed the constructor update |
mjsax
changed the title
bbejeck
approved these changes
Nov 18, 2025
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks for the fix @gensericghiro! LGTM
Member
|
Merged #20906 into trunk |
mjsax
pushed a commit
that referenced
this pull request
Nov 21, 2025
## Summary As a follow-up to #20906, also removing the process-id tag from 4.1. This is because when working on KIP-1091, we mistakenly applied the process-id tag to all client-level metrics, rather than just the client-state, thread-state, and recording-level metrics as specified in the KIP. ## Tests Unit tests in `ClientMetricsTest.java` and `StreamsMetricsImplTest.java` Reviewers: Matthias Sax <[email protected]>, Bill Bejeck<[email protected]>
mjsax
pushed a commit
that referenced
this pull request
Nov 22, 2025
As a follow-up to #20906, also removing the process-id tag from 4.1. This is because when working on KIP-1091, we mistakenly applied the process-id tag to all client-level metrics, rather than just the client-state, thread-state, and recording-level metrics as specified in the KIP. Unit tests in `ClientMetricsTest.java` and `StreamsMetricsImplTest.java` Reviewers: Matthias Sax <[email protected]>, Bill Bejeck<[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When working on
KIP-1091,
we mistakenly applied the
process-idtag to all client-level metrics,rather than just the
client-state,thread-state, andrecording-levelmetrics as specified in the KIP. This issue came tolight while working on KIP-1221, which aimed to add the
application-idas a tag to the
client-statemetric introduced by KIP-1091. This PRremoves these tags from all metrics by default, and adds them to only
the
client-state(application-id + process-id) and therecording-level(process-id only)Reviewers: Matthias Sax[email protected] Bill
Bejeck[email protected]
Tests
Unit tests in
ClientMetricsTest.javaandStreamsMetricsImplTest.java