Skip to content

HIVE-29519: Redundant queryStartTime update #6386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deniskuzZ merged 1 commit into from
Mar 25, 2026
Merged

HIVE-29519: Redundant queryStartTime update #6386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ql/src/java/org/apache/hadoop/hive/ql/Driver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ private void runInternal(String command, boolean alreadyCompiled) throws Command

if (!alreadyCompiled) {
compileInternal(command, true);
} else {
driverContext.recordQueryStartTime();
}

DriverUtils.checkInterrupted(driverState, driverContext, "at acquiring the lock.", null, null);
Expand Down Expand Up @@ -273,14 +271,12 @@ private void validateCurrentSnapshot() throws CommandProcessorException {
driverContext.setRetrial(true);

compileInternal(context.getCmd(), true);
driverContext.setRetrial(false);

if (driverContext.getPlan().hasAcidResourcesInQuery()) {
driverTxnHandler.recordValidWriteIds();
driverTxnHandler.setWriteIdForAcidFileSinks();
}
// Since we're reusing the compiled plan, we need to update its start time for current run
driverContext.recordQueryStartTime();
driverContext.setRetrial(false);
}
// Re-check snapshot only in case we had to release locks and open a new transaction,
// otherwise exclusive locks should protect output tables/partitions in snapshot from concurrent writes.
Expand Down
4 changes: 0 additions & 4 deletions ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,4 @@ public void setExplainPlan(String explainPlan) {
public String getExplainPlan() {
return explainPlan;
}

public void recordQueryStartTime() {
plan.setQueryStartTime(queryDisplay.getQueryStartTime());

@abstractdog abstractdog Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you remove this, the only usage of plan.setQueryStartTime() is from TestHiveProtoLoggingHook, does it make sense to add @VisibleForTesting to setQueryStartTime to let the code readers know that they should not set this directly?

@deniskuzZ deniskuzZ Mar 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method was added by me, there were no usages except Driver

}
}
Loading