HIVE-29519: Redundant queryStartTime update#6386
Merged
Merged
Conversation
deniskuzZ
force-pushed
the
driver_refactor
branch
from
82ab365 to
63ed625
Compare
deniskuzZ
changed the title
deniskuzZ
force-pushed
the
driver_refactor
branch
from
63ed625 to
e365766
Compare
deniskuzZ
changed the title
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
Contributor
|
LGTM +1 (non-binding) |
Contributor
|
nit: unrelated to the patch, there is typo in destroyed: |
Aggarwal-Raghav
approved these changes
Mar 24, 2026
abstractdog
reviewed
Mar 25, 2026
| } | ||
|
|
||
| public void recordQueryStartTime() { | ||
| plan.setQueryStartTime(queryDisplay.getQueryStartTime()); |
Contributor
There was a problem hiding this comment.
if you remove this, the only usage of plan.setQueryStartTime() is from TestHiveProtoLoggingHook, does it make sense to add @VisibleForTesting to setQueryStartTime to let the code readers know that they should not set this directly?
Member
Author
There was a problem hiding this comment.
this method was added by me, there were no usages except Driver
abstractdog
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removes redundant queryStartTime update call
Why are the changes needed?
The Compiler.createPlan() always sets queryStartTime from QueryDisplay. So every compileInternal call already
handles the start time.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Jenkins