Repository navigation
Conversation
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
semantic_model_metric_metaand reconcile metric identities in the existing model transaction. Exact-name matches retain IDs; removed names are retired, and reintroduced names receive new IDs. Integrate model/parent deletion and GC across H2, MySQL, and PostgreSQL.Why are the changes needed?
Provide the identity foundation for schema-level metric discovery described in #14038, under #14036.
Depends on #14139. This draft currently includes its commits and needs rebasing after it merges.
Fixes #14140.
Does this PR introduce any user-facing change?
No public API changes.
How was this patch tested?
313 tests passed: 13 unit tests and 100 tests on each of H2, MySQL, and PostgreSQL, covering identity rules, concurrent writes, rollback, parent cascades, GC, and SQL upgrades.
Ran
coreUnitTestand the three core database test tasks with focused Semantic Model, parent lifecycle, garbage collector, and SQL script filters, using-PskipITs -PskipDockerTests=false. Spotless andgit diff --checkpassed.