Skip to content

[#14002] improvement(test): Add TestImages and fixtures for Moto, Ranger and Hive (part 2/6) - #14008

Open
nevzheng wants to merge 10 commits into
apache:mainfrom
nevzheng:claude/13900-tc-04-images-moto-ranger-hive
Open

nevzheng wants to merge 10 commits into
apache:mainfrom
nevzheng:claude/13900-tc-04-images-moto-ranger-hive

Conversation

@nevzheng

@nevzheng nevzheng commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

  • TestImages declares every test image in one place, overridable by environment variable.
  • BaseContainer subclasses can supply their own container, ready for official Testcontainers modules.
  • Moto, Ranger and Hive (version, auth) fixtures, with 28 test classes moved onto them; a container whose start fails is closed instead of leaking, even when closing it throws.

This PR includes the commits of the PRs below it. Review only its own commit: nevzheng/gravitino@claude/13900-tc-03-fixture-framework...claude/13900-tc-04-images-moto-ranger-hive

Why are the changes needed?

Part 2 of 6 of #14002.

Fix: #14002

Does this PR introduce any user-facing change?

No. Test code only.

How was this patch tested?

Unit tests; Docker runs of the Moto, Ranger and Hive modules.

Stack: #14103 → #14083 → #14084 → #14085 → #14005 → #14006 → #14052 → #14076 → #14007 → #14008 → #14009 → #14010 → #14011 → #14012 → #14013 → #14079 → #14077 → #14078 → #14086 → #14087 → #14088 → #14089 → #14090 → #14091 → #14094

@nevzheng nevzheng self-assigned this Oct 20, 2026
@nevzheng
nevzheng force-pushed the claude/13900-tc-04-images-moto-ranger-hive branch 9 times, most recently from 0a63913 to f0737d7 Compare October 21, 2026 06:19
@nevzheng
nevzheng force-pushed the claude/13900-tc-04-images-moto-ranger-hive branch from f0737d7 to 98918fe Compare October 21, 2026 07:09
@nevzheng
nevzheng force-pushed the claude/13900-tc-04-images-moto-ranger-hive branch from 98918fe to 1575d93 Compare October 21, 2026 17:20
@nevzheng
nevzheng force-pushed the claude/13900-tc-04-images-moto-ranger-hive branch 5 times, most recently from d8db9d8 to ac7b7ad Compare October 21, 2026 19:44
@nevzheng
nevzheng force-pushed the claude/13900-tc-04-images-moto-ranger-hive branch 2 times, most recently from 046d662 to 52f312b Compare October 21, 2026 21:16
@nevzheng
nevzheng force-pushed the claude/13900-tc-04-images-moto-ranger-hive branch 9 times, most recently from 0a4e53e to 6a0be04 Compare October 22, 2026 03:28
Design doc for apache#13900 and a rumdl config for design-docs/testing.
…e ContainerSuite lifecycle

- Log every container start with pull, start and readiness times; add test
  log4j configs so the lines show.
- Reset all ContainerSuite state in close(); key Hive by version; make the
  PostgreSQL retry wait; pin StarRocks; drop a dead start method.
- Poll readiness with no initial delay; run cleanDisk() only on real starts.
- idp-basic starts its containers once per run; Ryuk back on, unprivileged.
- Drop the suite-wide closes in Hive2, Flink and Spark ITs.
@nevzheng
nevzheng force-pushed the claude/13900-tc-04-images-moto-ranger-hive branch from 6a0be04 to 8854c79 Compare October 22, 2026 04:29
…est containers (part 1/6)

ContainerSpec, ContainerExtension and @FixtureContainer: a test declares a
container with a fixture annotation and receives it as a parameter or field.
Fixtures for Kafka, LocalStack, RustFS, StarRocks, OceanBase and Doris, with
their callers migrated.
…o, Ranger and Hive (part 2/6)

- TestImages declares every test image in one place.
- BaseContainer subclasses can supply their own container (ready for the
  official Testcontainers modules).
- Moto, Ranger and Hive (version, auth) fixtures.
- A container whose start fails is closed instead of leaking.
@nevzheng
nevzheng force-pushed the claude/13900-tc-04-images-moto-ranger-hive branch from 8854c79 to 79ebbfc Compare October 22, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask] Add a JUnit fixture framework for test containers and move every caller to it

1 participant