Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/python/src/lookup.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ impl Lookuper {

// Convert to Python with GIL
Python::attach(|py| match row_opt {
Some(compacted_row) => internal_row_to_dict(py, &compacted_row, &table_info),
Some(row) => internal_row_to_dict(py, &row, &table_info),
None => Ok(py.None()),
})
})
Expand Down
27 changes: 24 additions & 3 deletions crates/fluss/src/client/admin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ use crate::client::metadata::Metadata;
use crate::cluster::ServerNode;
use crate::metadata::{
DatabaseDescriptor, DatabaseInfo, JsonSerde, LakeSnapshot, PartitionInfo, PartitionSpec,
PhysicalTablePath, TableBucket, TableDescriptor, TableInfo, TablePath,
PhysicalTablePath, Schema, SchemaInfo, TableBucket, TableDescriptor, TableInfo, TablePath,
};
use crate::rpc::message::{
CreateDatabaseRequest, CreatePartitionRequest, CreateTableRequest, DatabaseExistsRequest,
DropDatabaseRequest, DropPartitionRequest, DropTableRequest, GetDatabaseInfoRequest,
GetLatestLakeSnapshotRequest, GetTableRequest, ListDatabasesRequest, ListPartitionInfosRequest,
ListTablesRequest, TableExistsRequest,
GetLatestLakeSnapshotRequest, GetTableRequest, GetTableSchemaRequestMsg, ListDatabasesRequest,
ListPartitionInfosRequest, ListTablesRequest, TableExistsRequest,
};
use crate::rpc::message::{ListOffsetsRequest, OffsetSpec};
use crate::rpc::{RpcClient, ServerConnection};
Expand Down Expand Up @@ -111,6 +111,27 @@ impl FlussAdmin {
Ok(())
}

/// Fetch the schema for `table_path` at the given `schema_id`. Pass
/// `None` to request the latest.
pub async fn get_table_schema(
Comment thread
fresh-borzoni marked this conversation as resolved.
Comment thread
fresh-borzoni marked this conversation as resolved.
&self,
table_path: &TablePath,
schema_id: Option<i32>,
) -> Result<SchemaInfo> {
let response = self
.admin_gateway()
.await?
.request(GetTableSchemaRequestMsg::new(table_path, schema_id))
.await?;

let schema_node: serde_json::Value = serde_json::from_slice(&response.schema_json)
.map_err(|e| Error::JsonSerdeError {
message: format!("Failed to parse schema_json: {e}"),
})?;
let schema = Schema::deserialize_json(&schema_node)?;
Ok(SchemaInfo::new(schema, response.schema_id))
}

pub async fn get_table_info(&self, table_path: &TablePath) -> Result<TableInfo> {
let response = self
.admin_gateway()
Expand Down
2 changes: 2 additions & 0 deletions crates/fluss/src/client/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ mod connection;
mod credentials;
pub mod lookup;
mod metadata;
mod schema_getter;
mod table;
mod write;

Expand All @@ -28,5 +29,6 @@ pub use connection::*;
pub use credentials::*;
pub use lookup::LookupClient;
pub use metadata::*;
pub(crate) use schema_getter::ClientSchemaGetter;
pub use table::*;
pub use write::*;
76 changes: 76 additions & 0 deletions crates/fluss/src/client/schema_getter.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//! Per-table schema cache that lazily fetches missing schema versions
//! from the coordinator. Used by the lookup path to decode rows that
//! predate the table's current schema.

use crate::client::admin::FlussAdmin;
use crate::error::{Error, Result};
use crate::metadata::{Schema, SchemaInfo, TablePath};
use parking_lot::RwLock;
use std::collections::HashMap;
use std::sync::Arc;

pub(crate) struct ClientSchemaGetter {
table_path: TablePath,
admin: Arc<FlussAdmin>,
/// Pre-seeded with the table's current schema so the dominant case
/// (every row written under the latest schema) needs zero RPCs.
cache: RwLock<HashMap<i32, Arc<Schema>>>,
}

impl ClientSchemaGetter {
pub fn new(table_path: TablePath, admin: Arc<FlussAdmin>, latest: SchemaInfo) -> Self {
let mut map = HashMap::new();
let (schema, schema_id) = latest.into_parts();
map.insert(schema_id, Arc::new(schema));
Self {
table_path,
admin,
cache: RwLock::new(map),
}
}

/// Concurrent fetches for the same id are not deduplicated; we
/// accept one redundant RPC in exchange for staying off
/// `tokio::sync` machinery. Schemas are immutable per id, so
/// last-write-wins on the cache insert is correct.
pub async fn get_schema(&self, schema_id: i32) -> Result<Arc<Schema>> {
if let Some(schema) = self.cache.read().get(&schema_id).cloned() {
return Ok(schema);
}

let info = self
.admin
.get_table_schema(&self.table_path, Some(schema_id))
.await?;
let (schema, fetched_id) = info.into_parts();
if fetched_id != schema_id {
return Err(Error::UnexpectedError {
message: format!(
"Requested schema id {schema_id}, but server returned schema id {fetched_id}"
),
source: None,
});
}
let schema = Arc::new(schema);

self.cache.write().insert(schema_id, Arc::clone(&schema));
Ok(schema)
}
}
Loading
Loading