-
Notifications
You must be signed in to change notification settings - Fork 41
[rust] lookup decoding schema id #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leekeiabstraction
merged 4 commits into
apache:main
from
fresh-borzoni:fix/lookup-schema-id
May 3, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7ea804a
[rust] lookup decoding schema_id e2e
fresh-borzoni 22f6057
[docs] Add get_table_schema and SchemaInfo to Rust api-reference
fresh-borzoni 9ef7b1f
[docs] Clarify Lookuper schema-snapshot semantics in LookupResult
fresh-borzoni 955e6b8
fix visibility
fresh-borzoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! Per-table schema cache that lazily fetches missing schema versions | ||
| //! from the coordinator. Used by the lookup path to decode rows that | ||
| //! predate the table's current schema. | ||
|
|
||
| use crate::client::admin::FlussAdmin; | ||
| use crate::error::{Error, Result}; | ||
| use crate::metadata::{Schema, SchemaInfo, TablePath}; | ||
| use parking_lot::RwLock; | ||
| use std::collections::HashMap; | ||
| use std::sync::Arc; | ||
|
|
||
| pub(crate) struct ClientSchemaGetter { | ||
| table_path: TablePath, | ||
| admin: Arc<FlussAdmin>, | ||
| /// Pre-seeded with the table's current schema so the dominant case | ||
| /// (every row written under the latest schema) needs zero RPCs. | ||
| cache: RwLock<HashMap<i32, Arc<Schema>>>, | ||
| } | ||
|
|
||
| impl ClientSchemaGetter { | ||
| pub fn new(table_path: TablePath, admin: Arc<FlussAdmin>, latest: SchemaInfo) -> Self { | ||
| let mut map = HashMap::new(); | ||
| let (schema, schema_id) = latest.into_parts(); | ||
| map.insert(schema_id, Arc::new(schema)); | ||
| Self { | ||
| table_path, | ||
| admin, | ||
| cache: RwLock::new(map), | ||
| } | ||
| } | ||
|
|
||
| /// Concurrent fetches for the same id are not deduplicated; we | ||
| /// accept one redundant RPC in exchange for staying off | ||
| /// `tokio::sync` machinery. Schemas are immutable per id, so | ||
| /// last-write-wins on the cache insert is correct. | ||
| pub async fn get_schema(&self, schema_id: i32) -> Result<Arc<Schema>> { | ||
| if let Some(schema) = self.cache.read().get(&schema_id).cloned() { | ||
| return Ok(schema); | ||
| } | ||
|
|
||
| let info = self | ||
| .admin | ||
| .get_table_schema(&self.table_path, Some(schema_id)) | ||
| .await?; | ||
| let (schema, fetched_id) = info.into_parts(); | ||
| if fetched_id != schema_id { | ||
| return Err(Error::UnexpectedError { | ||
| message: format!( | ||
| "Requested schema id {schema_id}, but server returned schema id {fetched_id}" | ||
| ), | ||
| source: None, | ||
| }); | ||
| } | ||
| let schema = Arc::new(schema); | ||
|
|
||
| self.cache.write().insert(schema_id, Arc::clone(&schema)); | ||
| Ok(schema) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.