[rust] lookup decoding schema id #517
Merged
leekeiabstraction merged 4 commits intoMay 3, 2026
Merged
Conversation
fresh-borzoni
changed the title
fresh-borzoni
commented
May 1, 2026
fresh-borzoni
force-pushed
the
fix/lookup-schema-id
branch
2 times, most recently
from
5e0717f to
0bb99b0
Compare
Member
Author
Contributor
charlesdong1991
left a comment
charlesdong1991
left a comment
There was a problem hiding this comment.
very nice PR!! just some nit comments!
Member
Author
|
@charlesdong1991 Ty for the review, answered comments, PTAL 🙏 |
charlesdong1991
approved these changes
May 3, 2026
Contributor
charlesdong1991
left a comment
charlesdong1991
left a comment
There was a problem hiding this comment.
the implementation looks good to me! great job!! @fresh-borzoni
Only a nitpick: i think we could update api-references a bit, not blocking and can be separate pr too.
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR, left a couple of comments.
fresh-borzoni
force-pushed
the
fix/lookup-schema-id
branch
from
0bb99b0 to
22f6057
Compare
Member
Author
|
@leekeiabstraction Ty for the review, addressed all comments, PTAL 🙏 |
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for addressing, left further comments.
Member
Author
|
@leekeiabstraction Ty, addressed 👍 |
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #508
Lookup rows now decode under the schema id they were written with, then project to the table's current schema. Index mapping matches by
column id(stable acrossALTER TABLE … RENAME).Side fix:
Column.idis now preserved throughSchemaJSON serde as it was silently dropped on the read path.