Skip to content

CASSSIDECAR-410: Fix StorageClientTest Docker API compatibility and improve CI test reporting #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyothsnakonisa merged 2 commits into from
Feb 17, 2026
Merged

CASSSIDECAR-410: Fix StorageClientTest Docker API compatibility and improve CI test reporting #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec88e89
CASSSIDECAR-410 Fix StorageClientTest Docker API compatibility and im…
jyothsnakonisa Feb 16, 2026
9fa57c1
updating comment
jyothsnakonisa Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ jobs:
name: unit-test-results-java-${{ matrix.java }}
path: |
**/build/test-results/test/**
**/build/test-results/containerTest/**
**/build/reports/tests/
retention-days: 30

Expand Down
1 change: 1 addition & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
0.3.0
-----
* Fix StorageClientTest Docker API compatibility and improve CI test reporting (CASSSIDECAR-410)
* Incorrect SSL Configuration Keys in CdcPublisher.secretsProvider() (CASSSIDECAR-401)
* Fix ClusterTopologyMonitor delay parsing error due to missing time unit suffix (CASSSIDECAR-406)
* Adding storage_port to instance configuration and metadata (CASSSIDECAR-399)
Expand Down
10 changes: 9 additions & 1 deletion server/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,15 @@ dependencies {
// Needed for snapshot manifest validation
integrationTestImplementation(group: 'com.fasterxml.jackson.datatype', name: 'jackson-datatype-jsr310', version: "${project.jacksonVersion}")

containerTestImplementation('com.adobe.testing:s3mock-testcontainers:2.17.0') // 3.x version do not support java 11

// GitHub-hosted runners require Docker API 1.44+ after Docker Engine 29.x upgrade (Feb 2026).
// s3mock-testcontainers 2.17.0 is needed for JDK 11 compatibility (3.x requires Java 17+), but it
// bundles an old testcontainers version. Excluding it and explicitly adding 1.21.4 for Docker API 1.44+ support.
containerTestImplementation('com.adobe.testing:s3mock-testcontainers:2.17.0') {
exclude group: 'org.testcontainers'
}
containerTestImplementation 'org.testcontainers:testcontainers:1.21.4'
Copy link
Contributor

@yifan-c yifan-c Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about advancing the test dependency? See the latest version

"com.adobe.testing:s3mock-testcontainers:4.11.0"

Copy link
Contributor Author

@jyothsnakonisa jyothsnakonisa Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like 3.x versions do not support JDK11 and all 2.x versions do not resolve to 1.44 Docker API version.

Copy link
Contributor

@yifan-c yifan-c Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I actually had the comment there that we cannot use 3.x version due to jdk version support. 🤦‍♂️

Can you update the comment to explain why supporting Dock API 1.44+ is required?

containerTestImplementation 'org.testcontainers:junit-jupiter:1.21.4'
}

test {
Expand Down