Skip to content

Comments

CASSSIDECAR-410: Fix StorageClientTest Docker API compatibility and improve CI test reporting#320

Merged
jyothsnakonisa merged 2 commits intoapache:trunkfrom
jyothsnakonisa:ci
Feb 17, 2026
Merged

CASSSIDECAR-410: Fix StorageClientTest Docker API compatibility and improve CI test reporting#320
jyothsnakonisa merged 2 commits intoapache:trunkfrom
jyothsnakonisa:ci

Conversation

@jyothsnakonisa
Copy link
Contributor

No description provided.

Copy link
Contributor

@frankgh frankgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jyothsnakonisa jyothsnakonisa force-pushed the ci branch 4 times, most recently from e6ffc68 to e1ec567 Compare February 17, 2026 02:16
// Exclude old testcontainers to force upgrade to 1.21.4 which supports Docker API 1.44+
exclude group: 'org.testcontainers'
}
containerTestImplementation 'org.testcontainers:testcontainers:1.21.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about advancing the test dependency? See the latest version

"com.adobe.testing:s3mock-testcontainers:4.11.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like 3.x versions do not support JDK11 and all 2.x versions do not resolve to 1.44 Docker API version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I actually had the comment there that we cannot use 3.x version due to jdk version support. 🤦‍♂️

Can you update the comment to explain why supporting Dock API 1.44+ is required?

…prove CI test reporting

Patch by Jyothsna Konisa; Reviewed by Yifan Cai and Francisco Guerrero for CASSSIDECAR-410
@jyothsnakonisa jyothsnakonisa changed the title CASSSIDECAR-410: Collect the containerTest result in the CI CASSSIDECAR-410: Fix StorageClientTest Docker API compatibility and improve CI test reporting Feb 17, 2026
@jyothsnakonisa jyothsnakonisa merged commit 7ef18f0 into apache:trunk Feb 17, 2026
60 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants