CASSSIDECAR-410: Fix StorageClientTest Docker API compatibility and improve CI test reporting#320
Merged
jyothsnakonisa merged 2 commits intoapache:trunkfrom Feb 17, 2026
Merged
Conversation
yifan-c
approved these changes
Feb 17, 2026
e6ffc68 to
e1ec567
Compare
yifan-c
reviewed
Feb 17, 2026
| // Exclude old testcontainers to force upgrade to 1.21.4 which supports Docker API 1.44+ | ||
| exclude group: 'org.testcontainers' | ||
| } | ||
| containerTestImplementation 'org.testcontainers:testcontainers:1.21.4' |
Contributor
There was a problem hiding this comment.
What about advancing the test dependency? See the latest version
"com.adobe.testing:s3mock-testcontainers:4.11.0"
Contributor
Author
There was a problem hiding this comment.
looks like 3.x versions do not support JDK11 and all 2.x versions do not resolve to 1.44 Docker API version.
Contributor
There was a problem hiding this comment.
True. I actually had the comment there that we cannot use 3.x version due to jdk version support. 🤦♂️
Can you update the comment to explain why supporting Dock API 1.44+ is required?
…prove CI test reporting Patch by Jyothsna Konisa; Reviewed by Yifan Cai and Francisco Guerrero for CASSSIDECAR-410
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.