GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC#49284
Conversation
justing-bq
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
github-actions
Bot
added
CI: Extra: C++
justing-bq
changed the title
|
|
|
@lidavidm this PR is ready for review. Please take a look when you can. |
|
@kou, any concerns? |
github-actions
Bot
added
awaiting merge
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
Why do you need both of release and debug builds?
May we have any problems only with release build?
| - { architecture: ARM64, macos-version: "14", build_type: release } | ||
| env: | ||
| ARROW_BUILD_TESTS: ON | ||
| ARROW_BUILD_TYPE: ${{ matrix.build_type }} |
There was a problem hiding this comment.
Could you use build-type not build_type like we did for macos-version?
github-actions
Bot
added
awaiting changes
alinaliBQ
force-pushed
the
gh-49283-release-debug-macos
branch
from
f96c506 to
853fcc4
Compare
github-actions
Bot
added
awaiting change review
I don't think there will be issues if we just have release build. We were thinking that if both release and debug versions build on macOS in the CI, it would be good to test both for more coverage. |
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
Addressing kou's comments
| - { architecture: ARM64, macos-version: "14", build_type: release } | ||
| env: | ||
| ARROW_BUILD_TESTS: ON | ||
| ARROW_BUILD_TYPE: ${{ matrix.build_type }} |
|
OK. Could you add an explanation why we want to add release build to the PR description or associated issue? Could you fix CI failures? |
alinaliBQ
force-pushed
the
gh-49283-release-debug-macos
branch
from
853fcc4 to
ca3219b
Compare
Replace `build_type` with `build-type`
alinaliBQ
force-pushed
the
gh-49283-release-debug-macos
branch
from
ca3219b to
2988340
Compare
|
@kou Yes of course. I have posted a comment #49283 (comment) since Justin is currently out of office and I don't have edit access to the issue or PR. Thanks for catching the failure, I have fixed it in the workflows. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bbf337b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ws for MacOS ODBC (apache#49284) ### Rationale for this change Addresses apache#49283 ### What changes are included in this PR The ODBC MacOS workflows now have release and debug workflows. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#49283 Lead-authored-by: justing-bq <62349012+justing-bq@users.noreply.github.com> Co-authored-by: Alina (Xi) Li <alinal@bitquilltech.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
4 participants
Rationale for this change
Addresses #49283
What changes are included in this PR
The ODBC MacOS workflows now have release and debug workflows.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.