Skip to content

Conversation

margalva
Copy link
Collaborator

Move the docutils requirement from main dependency to documentation dependency, so it's not shipped with pydynamicreporting.

@margalva margalva requested a review from viseshrp October 14, 2025 16:46
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.65%. Comparing base (b353903) to head (4757ed3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files          28       28           
  Lines        7975     7975           
  Branches     1466     1466           
=======================================
  Hits         6512     6512           
  Misses        996      996           
  Partials      467      467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"Sphinx",
"sphinx-copybutton",
"sphinx-gallery",
"docutils>=0.21",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time I checked, this is technically not just a doc dependency but is also necessary for django/serverless to run.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may not be the case anymore. Can you run a local test of serverless without the dependency and confirm it works? Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From quick research:
Django itself doesn’t need docutils. The only built-in part of Django that uses it is the optional django.contrib.admindocs app, which renders reStructuredText from docstrings in the admin. If admindocs (or a third-party package that imports it) is in play, you’ll see ModuleNotFoundError: No module named 'docutils' at import time.

We actually do have this in our codebase, although I think this may not be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants