-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/yuanrui/enhanced images #135
Conversation
@zhang-yuanrui I don't want to add dpf and vtk as requirements for pydynamicreporting. Please see how report_download_pdf.py handles a similar situation with PyQt5. If the module exists, then methods are defined. If it doesn't exist, then the module does nothing. I'd like to see something similar here. I'd also like to see some tests added in the tests/ directory for these methods. You should add in the pyproject.toml the requirements for the extra modules only for tests (and maybe development), and create a few tests for these methods. Let me know if you need help here. |
I think my biggest comment here is the lack of example(s) and test cases. One can work around the dependency issues for tests that @margalva calls out using the yaml test deps target. My other big concern is the impact on sphinx documentation. There are a number of "internal" functions exposed here that one would like to avoid getting into the docs. Hiding them as '_' methods in a class would help. Consider providing a simple class with a pure VTK interface and the appropriate methods hidden. The DPF methods can move over into DPF and leverage the VTK interface from there, streamlining the dependencies. |
@randallfrank What is the yaml test deps target? |
…amicreporting into feat/yuanrui/enhanced_images
…yuanrui/enhanced_images
…yuanrui/enhanced_images
… be used only when python version is less than 3.12
Consolidate the first version of the enhanced image module.
What it can accomplish:
Known problems:
Potential next-step development: