-
Notifications
You must be signed in to change notification settings - Fork 1
Various improvements to streamline example code #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4aeb607
Initial prototypes for workflow and examples
janvonrickenbach 8bcfa09
Move to_pvista function to individual data points
janvonrickenbach 80ff74d
Cleanup example
janvonrickenbach b81ed76
Fix component names in mesh data
janvonrickenbach 40f5444
Initial prototypes for workflow and examples
janvonrickenbach d88d2f4
Document upload and download
janvonrickenbach 2152ab7
Remove unneeded readme parts
janvonrickenbach f3faadd
Initial prototypes for workflow and examples
janvonrickenbach 7702f4f
Improve plotting API
janvonrickenbach 7e2c94a
Move temp directory logic from ACP Client to ACP workflow
janvonrickenbach d6c4204
Merge with main
janvonrickenbach 5f7f062
Add type hints for plot data objects
janvonrickenbach d2e6ef8
Get example files from example-data repo
janvonrickenbach 8ce6887
Fix download location of example
janvonrickenbach 3f3c5e6
Fix package structure and add documentation
janvonrickenbach bc7f779
Delay import of ansys-dpf-composites
janvonrickenbach db17cab
Finish tree printer
janvonrickenbach b11678e
Add tests for workflow
janvonrickenbach fe570fb
Merge branch 'main' into feat/cleanup_for_release
janvonrickenbach 35d4295
Add type checks for plots
janvonrickenbach 153de9c
Return labels the same way as other data.
janvonrickenbach 2b2e8cc
Convert unit systems.
janvonrickenbach 8d12d56
Delay imports from dpf core
janvonrickenbach 92128de
Remove obsolete local example
janvonrickenbach ec44b32
Remove obsolete local example
janvonrickenbach cb2c796
Remove obsolete local example
janvonrickenbach 116231c
Fix docstring
janvonrickenbach 2e23309
Avoid modifications of input files and fix doc
janvonrickenbach a4c3acd
Remove obsolete input file
janvonrickenbach d5d6b47
Implement PR comments
janvonrickenbach 581386a
Improve tree printer
janvonrickenbach 73d57f9
Update src/ansys/acp/core/_workflow.py
janvonrickenbach f448438
Update src/ansys/acp/core/_workflow.py
janvonrickenbach ddc2f37
Update src/ansys/acp/core/_workflow.py
janvonrickenbach 4e912b9
Fix renames
janvonrickenbach fb0dba0
Better import error for optional dependencies
janvonrickenbach 22c0bc4
Fix renames
janvonrickenbach 423b387
Fix examples title
janvonrickenbach 560a9c3
Remove note on docker containers from example readme
janvonrickenbach af1b49c
Close open dpf streams by setting composite model to None
janvonrickenbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,19 +153,9 @@ You will need to follow these steps: | |
|
||
poetry shell | ||
|
||
.. TODO: If we add tox, add instructions on its use here. | ||
|
||
.. 6. Verify your development installation by running: | ||
|
||
.. .. code-block:: bash | ||
|
||
.. tox | ||
|
||
Testing | ||
^^^^^^^ | ||
|
||
.. TODO: If we add tox, add instructions on its use here. | ||
|
||
The PyACP test suite uses `pytest`_. You can run it with | ||
|
||
.. code-block:: bash | ||
|
@@ -210,16 +200,9 @@ need to create a commit without running the hooks, you can skip them with ``git | |
|
||
Documentation | ||
^^^^^^^^^^^^^ | ||
|
||
To build the documentation, DPF Composites and MAPDL servers need to be running: | ||
|
||
.. code-block:: bash | ||
|
||
docker-compose -f docker-compose/docker-compose-extras.yaml up -d | ||
|
||
In addition, the PyACP server needs to be configured via ``ansys-launcher``, see `Launching ACP <launching_server>`_ above. | ||
|
||
It can then be built using `Sphinx`_. | ||
Before generating the documentation, configure the PyACP server via the | ||
``ansys-launcher``, see `Launching ACP <launching_server>`_ above. | ||
If Ansys is installed the examples can directly built with `Sphinx`_. | ||
|
||
On Linux & MacOS: | ||
|
||
|
@@ -235,6 +218,20 @@ On Windows: | |
|
||
The generated HTML files can be viewed with the browser of your choice. | ||
|
||
Alternatively you can build the documentation by starting a mapdl and pydpf-composites docker | ||
container. First ensure that you have accepted the DPF Preview License Agreement by setting the | ||
ANSYS_DPF_ACCEPT_LA environment variable to Y | ||
(see `DPF Preview License Agreement <https://dpf.docs.pyansys.com/version/stable/user_guide/getting_started_with_dpf_server.html#dpf-preview-license-agreement>`_ | ||
). In addition the ANSYSLMD_LICENSE_FILE environment variable needs be set to a | ||
janvonrickenbach marked this conversation as resolved.
Show resolved
Hide resolved
|
||
valid license server (e.g [email protected]). Then start the docker containers with: | ||
|
||
.. code-block:: bash | ||
|
||
docker-compose -f docker-compose/docker-compose-extras.yaml up -d | ||
|
||
Then build the documentation with the `Sphinx`_ commands mentioned above. | ||
|
||
|
||
Distribution | ||
^^^^^^^^^^^^ | ||
|
||
|
@@ -264,4 +261,3 @@ License | |
.. _pre-commit: https://pre-commit.com/ | ||
.. _pytest: https://docs.pytest.org/en/stable/ | ||
.. _Sphinx: https://www.sphinx-doc.org/en/master/ | ||
.. _tox: https://tox.wiki/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,4 @@ and attributes. | |
linked_object_definitions | ||
material_property_sets | ||
other_types | ||
workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,3 +34,5 @@ ACP objects | |
ProductionPly | ||
AnalysisPly | ||
Sensor | ||
ScalarData | ||
VectorData |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Workflow | ||
-------- | ||
|
||
.. currentmodule:: ansys.acp.core | ||
|
||
.. autosummary:: | ||
:toctree: _autosummary | ||
|
||
ACPWorkflow | ||
get_composite_post_processing_files | ||
get_model_tree | ||
janvonrickenbach marked this conversation as resolved.
Show resolved
Hide resolved
|
||
get_dpf_unit_system | ||
print_model | ||
|
||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.