-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to streamline example code #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Some nit-picky discussion points below.
Check that declared plot data matches the runtime type.
I've just noticed the following: when running the tests with a local executable, we now get new and modified files (tracked by git) in the I haven't looked into it in detail, but if I'd have to guess: this is probably because the tests previously used a tempdir by default. |
Yes has been resovlved by creating additional temp directories in some tests. |
Co-authored-by: René Roos <[email protected]>
Co-authored-by: René Roos <[email protected]>
Co-authored-by: René Roos <[email protected]>
closes #343
closes #232
Todo:
Done
Postponed: