Unpin channels-redis #15329
Merged
Unpin channels-redis #15329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug that initially caused the upgrade block has been resolved django/channels_redis#332
Version 4.0.0 of channel-redis migrated the underlying Redis library from aioredis to redis-py. The Exception has been changed to an equivalent
github-actions
bot
added
component:api
dependencies
thedoubl3j
reviewed
Jul 23, 2024
| @@ -7,7 +7,7 @@ azure-keyvault | |||
| boto3 | |||
| botocore | |||
| channels | |||
| channels-redis==3.4.1 # see UPGRADE BLOCKERs | |||
| channels-redis | |||
There was a problem hiding this comment.
Do we want to fully unpin this given its upgrade blocker status before?
11 tasks
it was an indirect dependency from aioredis which was removed
Closed
it's potentially providing a performance boost. install explicitly as a part of redis. upgrade to more recent version
thedoubl3j
approved these changes
Jul 29, 2024
it was also addressed as a part of this PR
|
fosterseth
pushed a commit
to fosterseth/awx
that referenced
this pull request
Aug 30, 2024
* unpin channels-redis The bug that initially caused the upgrade block has been resolved django/channels_redis#332 * replace aioredis Exception with a redis Exception Version 4.0.0 of channel-redis migrated the underlying Redis library from aioredis to redis-py. The Exception has been changed to an equivalent * remove unused license * remove UPGRADE BLOCKER in README * remove hiredis it was an indirect dependency from aioredis which was removed * remove unused license * add back hiredis it's potentially providing a performance boost. install explicitly as a part of redis. upgrade to more recent version * remove UPGRADE BLOCKER for hiredis it was also addressed as a part of this PR
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
* unpin channels-redis The bug that initially caused the upgrade block has been resolved django/channels_redis#332 * replace aioredis Exception with a redis Exception Version 4.0.0 of channel-redis migrated the underlying Redis library from aioredis to redis-py. The Exception has been changed to an equivalent * remove unused license * remove UPGRADE BLOCKER in README * remove hiredis it was an indirect dependency from aioredis which was removed * remove unused license * add back hiredis it's potentially providing a performance boost. install explicitly as a part of redis. upgrade to more recent version * remove UPGRADE BLOCKER for hiredis it was also addressed as a part of this PR
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
* unpin channels-redis The bug that initially caused the upgrade block has been resolved django/channels_redis#332 * replace aioredis Exception with a redis Exception Version 4.0.0 of channel-redis migrated the underlying Redis library from aioredis to redis-py. The Exception has been changed to an equivalent * remove unused license * remove UPGRADE BLOCKER in README * remove hiredis it was an indirect dependency from aioredis which was removed * remove unused license * add back hiredis it's potentially providing a performance boost. install explicitly as a part of redis. upgrade to more recent version * remove UPGRADE BLOCKER for hiredis it was also addressed as a part of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The bug that initially caused the upgrade block has been resolved django/channels_redis#332.
As a result aioredis was removed because version 4.0.0 of channel-redis migrated the underlying Redis library from aioredis to redis-py..
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION