Upgrade hiredis #15390
Upgrade hiredis #15390
Conversation
was previously blocked because the package didn't provide source distribution on PyPi but this has been resolved
github-actions
bot
added
the
dependencies
There was a problem hiding this comment.
### hiredis
The hiredis 2.1.0 release doesn't provide source distribution on PyPI which prevents users to build that python package from the
sources.
Downgrading to 2.0.0 (which provides source distribution) until the channels-redis issue is fixed or a newer hiredis version is
available on PyPi with source distribution.
* https://github.com/redis/hiredis-py/issues/138
this is still in the UPGRADE BLOCKERs doc
can u check on it
|
also... is this requirement needed? or can just be deleted if its a indirect dependency it should be ok to just delete it |
we don't use hiredis directly so removing it from requirements. it will still be in requirements via aioredis
|
@TheRealHaoLiu I think you're correct about it being an indirect dependency so I've removed it. |
| # -r /awx_devel/requirements/requirements.in | ||
| # aioredis | ||
| hiredis==2.3.2 | ||
| # via aioredis |
There was a problem hiding this comment.
since aioredis is removed from the channel_redis upgrade to 4.x we can probably just remove hiredis
There was a problem hiding this comment.
updator need to be rerun after the channel_redis upgrade is merged
There was a problem hiding this comment.
@jessicamack can u roll this into the channel_redis PR?
There was a problem hiding this comment.
yes, we'll have to merge them in order but we can leave this one for last and run update so the requirements.txt is up to date
|
This work is being merged into #15329 |
SUMMARY
The requirement was previously blocked because the package didn't provide source distribution on PyPi but this has been resolved https://pypi.org/project/hiredis/2.3.2/#files
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION