fix: properly initialize rabbit health check#786
Merged
aneojgurhem merged 1 commit intomainfrom Oct 25, 2024
Merged
Conversation
7 tasks
ngruelaneo
approved these changes
Oct 25, 2024
ngruelaneo
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Properly initialize rabbit so that its health check does not return Unhealthy all the time preventing the container from starting when there is a health check set up.
Description
Variable
isInitialized_was not set totrue, forcing the health check to befalse.This variable was not needed as it is enough to check if the model (represents the underlying connection) is not null. When the model is null, the plugin is not initialized yet. This pr replace the variable by the proper checks on the model.
Testing
Health checks added by #785 were used to validate that this development properly initialises the health check.
Impact
RabbitMQ plugin initialization now works, allowing the usage of the plugin.
Checklist