fix: re-add health check for core images #785
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
force-pushed
the
jg/readdhc
branch
3 times, most recently
from
64c1df7 to
c34599b
Compare
aneojgurhem
requested review from
lemaitre-aneo,
ngruelaneo and
qdelamea-aneo
ngruelaneo
reviewed
Oct 25, 2024
7 tasks
aneojgurhem
added a commit
that referenced
this pull request
Oct 25, 2024
# Motivation Properly initialize rabbit so that its health check does not return Unhealthy all the time preventing the container from starting when there is a health check set up. # Description Variable `isInitialized_` was not set to `true`, forcing the health check to be `false`. This variable was not needed as it is enough to check if the model (represents the underlying connection) is not null. When the model is null, the plugin is not initialized yet. This pr replace the variable by the proper checks on the model. # Testing Health checks added by #785 were used to validate that this development properly initialises the health check. # Impact RabbitMQ plugin initialization now works, allowing the usage of the plugin. # Checklist - [x] My code adheres to the coding and style guidelines of the project. - [x] I have performed a self-review of my code. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have made corresponding changes to the documentation. - [x] I have thoroughly tested my modifications and added tests when necessary. - [x] Tests pass locally and in the CI. - [x] I have assessed the performance impact of my modifications.
aneojgurhem
force-pushed
the
jg/readdhc
branch
from
c34599b to
85356b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
[Include the reason behind these changes and any relevant context.]
Highlight the the improperly implemented health check fixed by #786.
Description
[Provide a detailled explanation of the modifications you have made. Link any related issues.]
Testing
[When applicable, detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]
Impact
[Discuss the impact of your modifications on ArmoniK. This might include effects on performance, configuration, documentation, new dependencies, or changes in behaviour.]
Additional Information
[Any additional information that reviewers should be aware of.]
Checklist