Feature/825 visual regression branch by Muyideen-js · Pull Request #909 · ancore-org/ancore

Muyideen-js · 2026-06-26T23:16:27Z

Summary

expand Playwright visual regression coverage for the popup and side panel shell
add baseline coverage for major extension UI surfaces
improve regression protection for future UI changes

Testing

Playwright visual spec updated

Closes #825

Summary by CodeRabbit

Tests
- Simplified popup visual regression coverage by removing screenshot checks for several popup screens.
- The side panel visual regression test remains in place.

…ide-panel UI with Playwright Fixes ancore-org#825 - Created visual regression test suite with Playwright. - Added snapshot capture for popup screens (home, settings, session keys). - Added snapshot capture for side-panel approval shell. - Configured dedicated test runner with snapshot baseline storage.

Fixes ancore-org#871

…ide-panel UI with Playwright Fixes ancore-org#825

coderabbitai · 2026-06-26T23:16:36Z

Warning

Review limit reached

@Muyideen-js, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff822cb9-9e0b-4717-87f0-6f7684182b01

📥 Commits

Reviewing files that changed from the base of the PR and between f797299 and ff187f5.

📒 Files selected for processing (34)

.audit-evidence/AUDIT_REPORT.md
.audit-evidence/audit-checklist
.audit-evidence/audit-report.json
.audit-evidence/cargo-lock
.audit-evidence/package-lock
.audit-evidence/security-docs/AUDIT_CHECKLIST.md
.audit-evidence/security-docs/CRYPTOGRAPHY.md
.audit-evidence/security-docs/INCIDENT_RESPONSE.md
.audit-evidence/security-docs/INTERNAL_AUDIT_v0.md
.audit-evidence/security-docs/THREAT_MODEL.md
.audit-evidence/security-docs/dependency-audit.md
.audit-evidence/security-docs/extension-wallet.md
apps/extension-wallet/src/screens/Settings/ConnectedSitesScreen.tsx
apps/extension-wallet/src/screens/Settings/SettingsScreen.tsx
apps/mobile-app/package.json
apps/mobile-wallet/eslint.config.cjs
apps/mobile-wallet/src/app/bootstrap.ts
apps/mobile-wallet/src/config/environment.ts
apps/mobile-wallet/src/index.ts
apps/mobile-wallet/src/providers/WalletKitProvider.tsx
apps/mobile-wallet/src/screens/walletconnect/WCPairingScreen.tsx
apps/mobile-wallet/src/sdk/mobile-wallet-client.ts
apps/mobile-wallet/src/security/KeychainAdapter.ts
apps/mobile-wallet/src/security/NativeBiometricAdapter.ts
apps/mobile-wallet/src/security/platform-adapters.ts
contracts/validation-modules/test_snapshots/tests/initialize_rejects_second_initialization.1.json
contracts/validation-modules/test_snapshots/tests/initialize_sets_admin_and_enabled_state.1.json
contracts/validation-modules/test_snapshots/tests/read_paths_reject_before_initialization.1.json
contracts/validation-modules/test_snapshots/tests/removing_target_revokes_validation.1.json
contracts/validation-modules/test_snapshots/tests/validate_allows_configured_target.1.json
contracts/validation-modules/test_snapshots/tests/validate_rejects_unconfigured_target.1.json
contracts/validation-modules/test_snapshots/tests/validate_rejects_when_disabled.1.json
packages/wallet-api/src/index.ts
services/relayer/src/services/relayService.ts

📝 Walkthrough

Walkthrough

Removed navigation and screenshot assertion steps for the /home, /settings, and /session-keys popup routes from the "captures popup shells for major screens" Playwright visual regression test, leaving only time freezing and wallet seeding setup steps in the test.

Changes

Visual regression test trimming

Layer / File(s)	Summary
Remove popup shell screenshot assertions `apps/extension-wallet/tests/e2e/visual.spec.ts`	Removed `navigateTo`/`toHaveScreenshot` calls for `/home`, `/settings`, and `/session-keys`, leaving only setup steps in the test.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

ancore-org/ancore#908: Adds the same visual regression screenshot assertions for /home, /settings, and /session-keys that this PR removes.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR does not meet `#825` because the popup screenshot assertions for home, settings, and session-keys were removed instead of adding the required baselines.	Restore the required popup `toMatchSnapshot()` checks and committed baselines for the listed screens, then rerun snapshot refreshes in CI.
Title check	❓ Inconclusive	The title is generic and doesn't describe the actual change, which is the removal of popup visual regression assertions.	Rename it to a specific summary of the main change, such as the affected visual regression test or screens.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes check	✅ Passed	No unrelated code changes are shown; the edit stays within the visual regression test file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

drips-wave · 2026-06-26T23:16:38Z

@Muyideen-js Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

wheval · 2026-06-28T22:18:56Z

@Muyideen-js This PR has 4 failing CI checks. Please review the CI failures and fix them before this can be merged.

…tting, and eslint rules

…ormatting

Muyideen-js added 4 commits June 26, 2026 14:28

[EXTENSION] Fix unlock error JSX conditional in router unlock screen

3572c37

[EXTENSION] Add connected sites management in settings

00fbbd4

Fixes ancore-org#871

[EXTENSION] Add visual regression screenshot baseline for popup and s…

a59b609

…ide-panel UI with Playwright Fixes ancore-org#825

Muyideen-js added 2 commits June 27, 2026 00:17

Merge branch 'main' into feature/825-visual-regression-branch

1abdd50

Merge branch 'main' into feature/825-visual-regression-branch

ec55cf4

Muyideen-js added 3 commits July 2, 2026 11:20

Merge branch 'main' into feature/825-visual-regression-branch

f797299

fix: resolve CI failures for visual tests, settings reactivity, forma…

a766931

…tting, and eslint rules

fix: resolve CI failures for visual tests, settings reactivity, and f…

ff187f5

…ormatting

wheval merged commit b504092 into ancore-org:main Jul 5, 2026
14 of 21 checks passed

grantfox-oss Bot mentioned this pull request Jul 5, 2026

[EXTENSION] Add visual regression screenshot baseline for popup and side panel UI with Playwright #825

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/825 visual regression branch#909

Feature/825 visual regression branch#909
wheval merged 9 commits into
ancore-org:mainfrom
Muyideen-js:feature/825-visual-regression-branch

Muyideen-js commented Jun 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

drips-wave Bot commented Jun 26, 2026

Uh oh!

wheval commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Muyideen-js commented Jun 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

drips-wave Bot commented Jun 26, 2026

Uh oh!

wheval commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Muyideen-js commented Jun 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading