Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"open": "^11.0.0",
"posthog-node": "^5.45.2",
"superjson": "^2.2.6",
"tldts": "^7.0.19",
"yaml": "^2.9.0",
"zustand": "^5.0.14"
},
Expand Down
24 changes: 24 additions & 0 deletions packages/core/src/server/requestOrigin.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { describe, expect, it } from "vitest";

import { resolveWidgetDomain } from "./requestOrigin.js";

describe("resolveWidgetDomain", () => {
it("returns the registrable domain for an ordinary subdomain", () => {
expect(resolveWidgetDomain("https://capitals.skybridge.tech")).toBe(
"skybridge.tech",
);
});

it("keeps tenants isolated on private suffixes", () => {
expect(resolveWidgetDomain("https://alice.github.io")).toBe(
"alice.github.io",
);
expect(resolveWidgetDomain("https://bob.github.io")).toBe("bob.github.io");
});

it("keeps the origin fallback for non-registrable hosts", () => {
expect(resolveWidgetDomain("http://localhost:3000")).toBe(
"http://localhost:3000",
);
});
});
8 changes: 8 additions & 0 deletions packages/core/src/server/requestOrigin.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { getDomain } from "tldts";

/**
* Resolves this server's public origin from request headers, in precedence
* `x-forwarded-host` → `host` → localhost dev fallback. Shared by view serving
Expand All @@ -24,3 +26,9 @@ export function resolveServerOrigin(
}
return `http://localhost:${process.env.__PORT || "3000"}`;
}

/** Resolve the registrable host used as the default widget security domain. */
export function resolveWidgetDomain(serverOrigin: string): string {
const hostname = new URL(serverOrigin).hostname;
Comment thread
AnayGarodia marked this conversation as resolved.
return getDomain(hostname, { allowPrivateDomains: true }) ?? serverOrigin;
}
4 changes: 2 additions & 2 deletions packages/core/src/server/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import type {
McpWildcard,
} from "./middleware.js";
import { buildMiddlewareChain, getHandlerMaps } from "./middleware.js";
import { resolveServerOrigin } from "./requestOrigin.js";
import { resolveServerOrigin, resolveWidgetDomain } from "./requestOrigin.js";
import {
discoverSkills,
registerSkills,
Expand Down Expand Up @@ -1127,7 +1127,7 @@ export class McpServer<
{
resourceDomains: [serverUrl],
connectDomains,
domain: serverUrl,
domain: resolveWidgetDomain(serverUrl),
baseUriDomains: [serverUrl],
},
contentMetaOverrides,
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/test/view.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ describe("McpServer.registerTool (unified API)", () => {
}>;
expect(appsSdkResourceCallback).toBeDefined();

const host = "myapp.com";
const host = "capitals.skybridge.tech";
const serverUrl = `https://${host}`;
const mockExtra = createMockExtra(host) as unknown as RequestHandlerExtra<
ServerRequest,
Expand All @@ -207,7 +207,7 @@ describe("McpServer.registerTool (unified API)", () => {
connectDomains: [serverUrl],
baseUriDomains: [serverUrl],
},
domain: serverUrl,
domain: "skybridge.tech",
description: "Test view",
},
"openai/widgetDescription": "Test view",
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading