fix(core): derive widget domain from registrable host - #991
Open
AnayGarodia wants to merge 2 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR derives the default widget domain from the server's registrable hostname. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Reviews (2): Last reviewed commit: "fix(core): isolate private-suffix widget..." | Re-trigger Greptile |
Collaborator
|
Hi @AnayGarodia, thanks for your contribution! Since this is your first time contributing to the Skybridge repository, would you mind introducing yourself on our Discord? We'd love to get to know our contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses tldts to derive the default widget domain from the server hostname. A server such as capitals.skybridge.tech now emits skybridge.tech, while localhost and other non-registrable hosts safely retain the existing origin fallback.
Closes #359
Testing